Persist MAC generator ID used by a given app #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3665 +/- ##
==========================================
- Coverage 19.65% 19.61% -0.04%
==========================================
Files 232 232
Lines 50680 50742 +62
==========================================
- Hits 9959 9951 -8
- Misses 39998 40068 +70
Partials 723 723 ☔ View full report in Codecov by Sentry. |
milan-zededa
force-pushed
the
persist-mac-version
branch
from
df56767 to
26b57b5
Compare
rouming
approved these changes
Dec 13, 2023
Persisting MAC address generator ID avoids changing MAC addresses for already deployed apps, even when the option network.local.legacy.mac.address is changed by the user. Only newly deployed apps will apply the latest config change and use the most recently selected MAC generator. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
persist-mac-version
branch
from
26b57b5 to
2d41acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persisting MAC address generator ID avoids changing MAC addresses for
already deployed apps, even when the option
network.local.legacy.mac.addressis changed by the user. Only newly deployed apps will apply the latest config
change and use the most recently selected MAC generator.