Fix VLANs and LAGs #3697
Merged
Fix VLANs and LAGs #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for VLANs and LAGs has been added to EVE quite some time ago, but it has not been retested since. As we are soon planning to productize this feature, this commit contains a set of patches for regressions found while testing EVE with VLAN and LAG configurations. Patches are mostly about skipping L2-only ports and not trying to use them for connectivity tests and HTTP requests. Signed-off-by: Milan Lenco <milan@zededa.com>
github-actions
bot
requested review from
christoph-zededa,
jsfakian,
OhmSpectator and
uncleDecart
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3697 +/- ##
==========================================
- Coverage 19.60% 19.52% -0.09%
==========================================
Files 232 232
Lines 50789 50787 -2
==========================================
- Hits 9959 9917 -42
- Misses 40104 40137 +33
- Partials 726 733 +7 ☔ View full report in Codecov by Sentry. |
eriknordmark
reviewed
Jan 8, 2024
| @@ -1684,29 +1684,6 @@ func doActivateTail(ctx *domainContext, status *types.DomainStatus, | |||
| status.UUIDandVersion, status.DisplayName) | |||
| } | |||
|
|
|||
| // VLAN filtering could have been enabled on the bridge immediately after | |||
There was a problem hiding this comment.
Is this no longer needed due to some unknown netlink code? (New kernel version??)
There was a problem hiding this comment.
Some time ago, this was moved from domainmgr to zedrouter (NI Reconciler): https://github.com/lf-edge/eve/blob/master/pkg/pillar/nireconciler/linuxitems/vlanbridge.go#L106-L131
I just forgot to remove this no longer used function back then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for VLANs and LAGs has been added to EVE quite some time ago, but it has not been retested since. As we are soon planning to productize this feature, this PR contains a set of patches for regressions found while testing EVE with VLAN and LAG configurations.
Patches are mostly about skipping L2-only ports and not trying to use them for connectivity tests and HTTP requests.
I have also prepared an example for eden: lf-edge/eden#939
Hopefully in the near future we will be able to turn this into a fully automated test.