tools: Fix kernel asset for NET installer #3702
Conversation
Due to the kernel build changes, the kernel binary asset is not copied to bits/ folder anymore, leading to the following error of the tools/makenet.sh script while building NET installer images: ipxe.efi.cfg tar: kernel: No such file or directory initrd.img installer.img initrd.bits rootfs.img tar: error exit delayed from previous errors Now that different kernel packages can be specified with the KERNEL_TAG variable, an approach to fix this issue is to pick the kernel image directly from the final rootfs image. However, this would require manipulate the rootfs image inside the Alpine container used by the makenet.sh script. An easier way (implemented by this commit) is to use the rootfs tarball and pick the kernel image from there, which will work regardless of the type of the rootfs image (squashfs, ext4, etc). Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
|
LGTM |
|
Unit tests failing here are not related to the changes of this PR... they are failing on master as well... |
I will fix those in separate PR (DONE: #3703), just ignore it here. |
Yeah, that's strange, but the errors are there as well, for instance: https://github.com/lf-edge/eve/actions/runs/7423588723/job/20201342206#step:3:633, https://github.com/lf-edge/eve/actions/runs/7423588723/job/20201342206#step:3:446 |
I know, but the point is that if check is green nobody will look inside and failures thus propagate to another PR. |
Due to the kernel build changes, the kernel binary asset is not copied to bits/ folder anymore, leading to the following error of the tools/makenet.sh script while building NET installer images:
Now that different kernel packages can be specified with the KERNEL_TAG variable, an approach to fix this issue is to pick the kernel image directly from the final rootfs image. However, this would require manipulate the rootfs image inside the Alpine container used by the makenet.sh script. An easier way (implemented by this commit) is to use the rootfs tarball and pick the kernel image from there, which will work regardless of the type of the rootfs image (squashfs, ext4, etc).