-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Hailo 8 FW #3719
Integrate Hailo 8 FW #3719
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3719 +/- ##
==========================================
+ Coverage 17.51% 19.60% +2.08%
==========================================
Files 3 232 +229
Lines 805 50770 +49965
==========================================
+ Hits 141 9953 +9812
- Misses 629 40094 +39465
- Partials 35 723 +688 ☔ View full report in Codecov by Sentry. |
pkg/fw/Dockerfile
Outdated
@@ -61,6 +61,12 @@ ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM4345C0.hcd . | |||
ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM43430B0.hcd . | |||
ADD ${RPI_BT_FIRMWARE_URL}/${RPI_BT_FIRMWARE_VERSION}/broadcom/BCM4345C5.hcd . | |||
|
|||
# Hailo GPU firmware | |||
# we've got a written permission to include this firmware into EVE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think we must take this with precaution. Although it's a firmware blob, so we are not talking about source code to be included on EVE, this written permission should be compatible with Apache 2.0, which means that it should not forbid us in anyway from any of the permissions guaranteed by our license: rights to use the software as it is, rights to change it (EVE), rights to share it... since it's a firmware blob, perhaps the most important is the right to share it as we wish (within EVE, of course)... I think it's important to include a license file here, we do have proprietary firmware in this package (i.MX, NVIDIA), but they have specific (proprietary) licenses that allows to share, pack with EVE, etc, i.e., which doesn't break the terms of our license...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rene yes, sure. I've submitted this PR as a placeholder so I do not loose the code. still waiting for confirmation and proper license file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be feasible to download it during VM deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be feasible to download it during VM deployment.
not really, the end user must accept EULA but we managed to get approval from Hailo
f39bd53
to
37def24
Compare
37def24
to
76c4a73
Compare
Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
76c4a73
to
2214416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.