Do not try to use invalid network config #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-zededa
requested review from
eriknordmark
and removed request for
eriknordmark
github-actions
bot
requested review from
christoph-zededa,
OhmSpectator and
uncleDecart
milan-zededa
force-pushed
the
invalid-net-config
branch
from
dd1e1b7 to
de51dd1
Compare
|
Is this a bug fix which needs to be backported to stable releases? |
Yes, I added the stable label. |
milan-zededa
force-pushed
the
invalid-net-config
branch
from
de51dd1 to
a11e8e2
Compare
milan-zededa
force-pushed
the
invalid-net-config
branch
from
a11e8e2 to
fa7fe6a
Compare
Even if zedagent detects invalid network config and reports DPC with error, NIM may still try to use it, run connection tests and overwrite the error with another or even with nil. Instead, NIM should skip mgmt ports with invalid config and preserve the error (incl. across reboots). Similarly, DPC reconciler should not try to apply invalid config into the network stack. Additionally, diag was extended to report when port config is not valid. Lastly, readability of some parsing error messages was improved. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
invalid-net-config
branch
from
fa7fe6a to
fc0eb7e
Compare
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if zedagent detects invalid network config and reports DPC with error, NIM may still try to use it, run connection tests and overwrite the error with another or even with nil.
Instead, NIM should skip mgmt ports with invalid config and preserve the error (incl. across reboots).
Similarly, DPC reconciler should not try to apply invalid config into the network stack.
Additionally, diag was extended to report when port config is not valid.
Lastly, readability of some parsing error messages was improved.