Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0-stable] pillar: Release CPUs on domain activation failure #3960

Conversation

OhmSpectator
Copy link
Member

Backport #3952 into 11.0.

This commit addresses an issue where CPUs assigned to a domain within
doActivate() are not released if the domain activation fails. The new
logic ensures that CPUs are properly released and the CPU mask in the
status is updated accordingly. This is achieved by introducing the
releaseCPUs function and calling it in the appropriate error handling
blocks within doActivate().

It is common for doActivate to fail in scenarios such as switching
application profiles that share the same adapter. In such cases, the
second application will fail to activate until the first one releases
the necessary adapter.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
(cherry picked from commit 10c924e)
@rouming
Copy link
Contributor

rouming commented Jun 3, 2024

@OhmSpectator don't forget to target the 12.0-stable as well.

@OhmSpectator
Copy link
Member Author

target

As I understand, we don't have 12.0 stable. As far as I understand, we accumulate fixes now and will make a stable release based on one of 12.* tags. And this fix is a part of 12.3. Or am I wrong?

@rouming
Copy link
Contributor

rouming commented Jun 3, 2024

We have a branch now: eve/12.0-stable. If you need to backport there - please do that as well.

@OhmSpectator
Copy link
Member Author

@rouming, yep, I see it now. Will do.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 1bdd30b into lf-edge:11.0-stable Jun 5, 2024
28 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants