Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in TestVlansAndBonds #3993

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

milan-zededa
Copy link
Contributor

@milan-zededa milan-zededa commented Jun 21, 2024

I have accidentaly added duplicate call to release() in TestVlansAndBonds as part of my recently merged PR.

This can trigger panic:

goroutine 52 [running]:
sync.fatal({0x17540dd?, 0xffffffff?})
	/usr/lib/go/src/runtime/panic.go:1031 +0x1e
sync.(*Mutex).unlockSlow(0xc0004bee00, 0xffffffff)
	/usr/lib/go/src/sync/mutex.go:229 +0x49
sync.(*Mutex).Unlock(0xc0004bee00)
	/usr/lib/go/src/sync/mutex.go:223 +0x55
github.com/lf-edge/eve/pkg/pillar/dpcreconciler.(*LinuxDpcReconciler).pauseWatcher.func1()
	/pillar/dpcreconciler/linux.go:272 +0x73
github.com/lf-edge/eve/pkg/pillar/dpcreconciler_test.TestVlansAndBonds(0xc00009ba00?)
	/pillar/dpcreconciler/linux_test.go:915 +0x2c16
testing.tRunner(0xc00009ba00, 0x17a82b8)
	/usr/lib/go/src/testing/testing.go:1576 +0x217
created by testing.(*T).Run
	/usr/lib/go/src/testing/testing.go:1629 +0x806

I have accidentaly added duplicate call to release() in TestVlansAndBonds
as part of my recently merged PR.

Signed-off-by: Milan Lenco <milan@zededa.com>
@github-actions github-actions bot requested a review from eriknordmark June 21, 2024 15:44
@milan-zededa milan-zededa requested a review from rouming June 21, 2024 15:44
@eriknordmark eriknordmark merged commit 4f1a850 into lf-edge:master Jun 22, 2024
21 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants