Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk group for mdev zvol enumeration #3996

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

andrewd-zededa
Copy link
Contributor

Resolve regression from commit 3f78153.

Touching /dev/mdev.log would show mdev errors like the below:

mdev[2051]: unknown user/group 'root:disk' on line 7

pkg/dom0-ztools/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add the comment @shjala asked for.

pkg/pillar/Dockerfile Outdated Show resolved Hide resolved
@andrewd-zededa
Copy link
Contributor Author

ERROR: failed to solve: golang:1.20.1-alpine: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/golang/manifests/sha256:87d0a3309b34e2ca732efd69fb899d3c420d3382370fd6e7e6d2cb5c930f27f9: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
make: *** [Makefile:944: eve-build-ubuntu] Error 1
Error: Process completed with exit code 2.

too many pulls on latest build...

@andrewd-zededa
Copy link
Contributor Author

Added a yetus header complaint fix in pkg/pillar/build-kubevirt.yml so that I could kick the build again.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run again

@andrewd-zededa
Copy link
Contributor Author

Pushed a rebase

@andrewd-zededa
Copy link
Contributor Author

newline on the yml file for yetus

@eriknordmark
Copy link
Contributor

newline on the yml file for yetus

What about the build failure in
https://github.com/lf-edge/eve/actions/runs/9668949206/job/26674312202?pr=3996

@andrewd-zededa
Copy link
Contributor Author

yeah I think the tag changed again, must have been during my rebase. One more try

@andrewd-zededa
Copy link
Contributor Author

I'm waiting for more builds to complete locally, the go tests failure is odd

@eriknordmark
Copy link
Contributor

I'm waiting for more builds to complete locally, the go tests failure is odd

Did you try a make test in your workspace?

Resolve regression from commit 3f78153
Fix yetus header for build-kubevirt.yml.

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
@andrewd-zededa
Copy link
Contributor Author

reverted the pkg/pillar/Dockerfile back to origin/master. Will push in separate pr.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewd-zededa
Copy link
Contributor Author

I'm waiting for more builds to complete locally, the go tests failure is odd

Did you try a make test in your workspace?

yeah, it failed for not having a local containerd to run against but ran many other tests. It didn't fail due to the dom0-ztools tag.

@andrewd-zededa
Copy link
Contributor Author

lf-edge/eden get-run-id failure (pull_request_review)

Error: No successful runs found
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:11:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:20)
Error: Unhandled error: Error: No successful runs found

I'm not sure what to make of this failure

@andrewd-zededa
Copy link
Contributor Author

lf-edge/eden get-run-id failure (pull_request_review)

Error: No successful runs found
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35424:16), <anonymous>:11:11)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (/home/runner/work/_actions/actions/github-script/v7/dist/index.js:35522:20)
Error: Unhandled error: Error: No successful runs found

I'm not sure what to make of this failure

never mind, it switched to skipped after resolving the pkg/pillar/Dockerfile changes needed. If this is merged I'll submit a PR to bump dom0-ztools tag in pillar.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run again

@eriknordmark eriknordmark merged commit e66b1fa into lf-edge:master Jun 26, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants