-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disk group for mdev zvol enumeration #3996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please add the comment @shjala asked for.
9bdc8be
to
d658cd8
Compare
d658cd8
to
3d101f3
Compare
too many pulls on latest build... |
3d101f3
to
aa672e5
Compare
Added a yetus header complaint fix in pkg/pillar/build-kubevirt.yml so that I could kick the build again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run again
aa672e5
to
642a83e
Compare
Pushed a rebase |
642a83e
to
71af633
Compare
newline on the yml file for yetus |
What about the build failure in |
71af633
to
106add1
Compare
yeah I think the tag changed again, must have been during my rebase. One more try |
I'm waiting for more builds to complete locally, the go tests failure is odd |
Did you try a make test in your workspace? |
Resolve regression from commit 3f78153 Fix yetus header for build-kubevirt.yml. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
106add1
to
ed4ebb8
Compare
reverted the pkg/pillar/Dockerfile back to origin/master. Will push in separate pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yeah, it failed for not having a local containerd to run against but ran many other tests. It didn't fail due to the dom0-ztools tag. |
lf-edge/eden get-run-id failure (pull_request_review)
I'm not sure what to make of this failure |
never mind, it switched to skipped after resolving the pkg/pillar/Dockerfile changes needed. If this is merged I'll submit a PR to bump dom0-ztools tag in pillar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run again
Resolve regression from commit 3f78153.
Touching /dev/mdev.log would show mdev errors like the below:
mdev[2051]: unknown user/group 'root:disk' on line 7