Metadata server: move persist pubsubs from zedrouter to msrv #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // override it | ||
| return os.RemoveAll(src) | ||
| } else { | ||
| if err := moveDir(src, dst); err != nil { |
There was a problem hiding this comment.
How about using fileutils.CopyDir?
There was a problem hiding this comment.
uncleDecart
force-pushed
the
add-upgrade-to-pe
branch
from
53ee701 to
3d9ac66
Compare
uncleDecart
force-pushed
the
add-upgrade-to-pe
branch
from
3d9ac66 to
88928fb
Compare
In case older version of EVE contained patch envelopes which needs to be saved Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart
force-pushed
the
add-upgrade-to-pe
branch
from
88928fb to
662f6f5
Compare
uncleDecart
changed the title
|
Tested locally with Eden. Worked like charm, files are there at msrv service and zedrouter files are also there |
milan-zededa
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case older version of EVE contained patch envelopes which needs to be saved.
Needs to be tested