pillar/device-steps.sh: fix global NTPSERVER var initialization #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milan-zededa
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
LGTM, but let's wait for #4051 to fix the build, then we will run the tests.
github-actions
bot
requested review from
milan-zededa,
OhmSpectator and
uncleDecart
On NTP servers restart NTPSERVER variable should be assigned, otherwise chrony will be reloaded with same values. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
If DeviceNetworkSatus/global.json is absent (race), handle empty string correctly and replace it with the default NTP pool. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
This commit ensures NTP servers are sorted and unique, so we avoid spurios NTP servers reload and do not try to add duplicates. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
Make error path of the `dialUnixWithChronyd()` cleaner by moving socket cleanup directly into the function. Also remove socket in case of `chmod()` error. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
milan-zededa
requested changes
Jul 8, 2024
milan-zededa
approved these changes
Jul 8, 2024
|
Tests passed OK (apart from smoke tests which is fixed in the latest master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few commits target the following:
dialUnixWithChronyd()cleaner by moving socket cleanup directly into the function.