Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/bpftrace: push empty image to dockerhub #4061

Conversation

christoph-zededa
Copy link
Contributor

this way we can work around the fact that get-deps does not build dependencies architecture specific and therefore tries to build bpftrace for riscv64
with this change an empty image will be pulled and put into the debug container on riscv64

other architectures stay the same as before

This fixes #4018

@christoph-zededa christoph-zededa force-pushed the include_bpftrace_by_src_part2.5_version2 branch 2 times, most recently from c9a9a19 to 263544e Compare July 8, 2024 11:37
@christoph-zededa
Copy link
Contributor Author

I changed how bpftrace-aotrt and it's dependencies get copied into the final container; instead of copying only it into /, now it gets copied in /bpftrace and the build environment is kept. This enables other users of lfedge/eve-bpftrace to build something and use bpftrace to create bpftrace-code for eve.

@rene
Copy link
Contributor

rene commented Jul 8, 2024

I changed how bpftrace-aotrt and it's dependencies get copied into the final container; instead of copying only it into /, now it gets copied in /bpftrace and the build environment is kept. This enables other users of lfedge/eve-bpftrace to build something and use bpftrace to create bpftrace-code for eve.

@christoph-zededa , but that means when you include the container into the rootfs the build environment will be included as well... is that intentional? What will be the difference in the final container's size?

@christoph-zededa
Copy link
Contributor Author

@christoph-zededa , but that means when you include the container into the rootfs the build environment will be included as well... is that intentional? What will be the difference in the final container's size?

this container will be included like this then:

COPY --from=bpftrace /bpftrace /

in #4018

So I don't think everything will be included in the rootfs image.

@rene
Copy link
Contributor

rene commented Jul 8, 2024

@christoph-zededa , but that means when you include the container into the rootfs the build environment will be included as well... is that intentional? What will be the difference in the final container's size?

this container will be included like this then:

COPY --from=bpftrace /bpftrace /

in #4018

So I don't think everything will be included in the rootfs image.

Ha, ok, yeah, all good, in the example above it will only copy contents of /bpftrace....

this way we can work around the fact that get-deps does
not build dependencies architecture specific and therefore
tries to build bpftrace for riscv64
with this change an empty image will be pulled and put into
the debug container on riscv64

other architectures stay the same as before

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
@christoph-zededa christoph-zededa force-pushed the include_bpftrace_by_src_part2.5_version2 branch from 263544e to e793be8 Compare July 8, 2024 16:40
@christoph-zededa
Copy link
Contributor Author

I changed how bpftrace-aotrt and it's dependencies get copied into the final container; instead of copying only it into /, now it gets copied in /bpftrace and the build environment is kept. This enables other users of lfedge/eve-bpftrace to build something and use bpftrace to create bpftrace-code for eve.

Now only bpftrace is kept in order to minimize the amount of bytes that have to be downloaded.

@eriknordmark eriknordmark merged commit 69c1fb7 into lf-edge:master Jul 9, 2024
31 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants