-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/bpftrace: push empty image to dockerhub #4061
pkg/bpftrace: push empty image to dockerhub #4061
Conversation
c9a9a19
to
263544e
Compare
I changed how bpftrace-aotrt and it's dependencies get copied into the final container; instead of copying only it into |
@christoph-zededa , but that means when you include the container into the rootfs the build environment will be included as well... is that intentional? What will be the difference in the final container's size? |
this container will be included like this then:
in #4018 So I don't think everything will be included in the rootfs image. |
Ha, ok, yeah, all good, in the example above it will only copy contents of /bpftrace.... |
this way we can work around the fact that get-deps does not build dependencies architecture specific and therefore tries to build bpftrace for riscv64 with this change an empty image will be pulled and put into the debug container on riscv64 other architectures stay the same as before Signed-off-by: Christoph Ostarek <christoph@zededa.com>
263544e
to
e793be8
Compare
Now only |
this way we can work around the fact that get-deps does not build dependencies architecture specific and therefore tries to build bpftrace for riscv64
with this change an empty image will be pulled and put into the debug container on riscv64
other architectures stay the same as before
This fixes #4018