Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Bump Eden version to 0.9.10 #4064

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

milan-zededa
Copy link
Contributor

Release notes can be found here:
https://github.com/lf-edge/eden/releases/tag/0.9.10

There is only one small patch fixing one of the initial steps of smoke tests.

@milan-zededa milan-zededa requested a review from rouming July 8, 2024 12:48
Release notes can be found here:
 https://github.com/lf-edge/eden/releases/tag/0.9.10

There is only one small patch fixing one of the initial steps
of smoke tests.

Signed-off-by: Milan Lenco <milan@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
Copy link
Contributor

@milan-zededa can you rebase this on master or otherwise twiddle it to see if that triggers the build workflow to run.

@milan-zededa
Copy link
Contributor Author

milan-zededa commented Jul 9, 2024

@milan-zededa can you rebase this on master or otherwise twiddle it to see if that triggers the build workflow to run.

So unfortunately we had to disable build workflows for PRs that make changes to workflow files: #4051
This is due to introducing docker login into the workflow. It depends on repo secrets (dockerhub username/password), which for a PR are accessible only when its workflows are triggered with pull_request_target. However, this comes with a security risk - anyone can change the workflow yml file, add step with echo ${{ secrets.RELEASE_DOCKERHUB_TOKEN }} and open a PR, which would start the build actions and the secret would be revealed. To avoid this, @yash-zededa disabled build workflows for PRs that change workflow files. This is of course not ideal, because we cannot test the changes until we merge. He has some ideas how to improve this (run build after approval) and will implement them in the near future.

@eriknordmark
Copy link
Contributor

Did this pass the Eden tests as good as before when run as part of the Eden PR which did this change? (Sorry can't dig it up myself - only have phone access )

@milan-zededa
Copy link
Contributor Author

Did this pass the Eden tests as good as before when run as part of the Eden PR which did this change? (Sorry can't dig it up myself - only have phone access )

Yes it did.

@eriknordmark eriknordmark merged commit 14138ea into lf-edge:master Jul 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants