Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only syscall.Stat() vol paths in metrics path #4065

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Only syscall.Stat() vol paths in metrics path #4065

merged 1 commit into from
Jul 11, 2024

Conversation

andrewd-zededa
Copy link
Contributor

Balance between syscall.Stat() everything with
the aim of very accurate allocated storage usage
or syscall.Stat() nothing which will miss the deltas of provisioned vs allocated storage.
Don't syscall.Stat() in the child directories of each volume path.

@andrewd-zededa
Only syscall.Stat() vol paths in metrics path
e7c8868 
Balance between syscall.Stat() everything with
the aim of very accurate allocated storage usage
or syscall.Stat() nothing which will miss the deltas
of provisioned vs allocated storage.
Don't syscall.Stat() in the child directories of each
volume path.

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
@github-actions github-actions bot requested a review from eriknordmark July 8, 2024 13:11
@andrewd-zededa
Copy link
Contributor Author

RateLimited...

ERROR: failed to solve: golang:1.20.1-alpine: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/golang/manifests/sha256:87d0a3309b34e2ca732efd69fb899d3c420d3382370fd6e7e6d2cb5c930f27f9: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
make: *** [Makefile:960: eve-build-runner] Error 1
Error: Process completed with exit code 2.

@deitch
Copy link
Contributor

deitch commented Jul 8, 2024

And it is rate limited on something that is unnecessary to pull, to wit, making eve-build-runner. Since that thing is consistent, I am going to work on getting a pre-built image for it.

@rouming rouming added the stable Should be backported to stable release(s) label Jul 8, 2024
@andrewd-zededa andrewd-zededa marked this pull request as ready for review July 10, 2024 20:27
milan-zededa
milan-zededa approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@milan-zededa milan-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run tests

@milan-zededa
Copy link
Contributor

All tests passed (on the first try!)

@eriknordmark eriknordmark merged commit dd5838a into lf-edge:master Jul 11, 2024
36 checks passed
@milan-zededa milan-zededa mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-zededa milan-zededa milan-zededa approved these changes

@eriknordmark eriknordmark Awaiting requested review from eriknordmark eriknordmark is a code owner

Assignees
No one assigned
Labels
stable Should be backported to stable release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewd-zededa @deitch @milan-zededa @rouming @eriknordmark