Correct GOOS for get-deps build on MacOS #4068
Conversation
andrewd-zededa
force-pushed
the
get-deps-cc
branch
from
27f5e5a to
08ea1eb
Compare
andrewd-zededa
force-pushed
the
get-deps-cc
branch
from
08ea1eb to
fa9516e
Compare
|
latest push is a rebase, we'll see how it does |
andrewd-zededa
force-pushed
the
get-deps-cc
branch
from
fa9516e to
0912754
Compare
|
@deitch pushed up your requested change for GOOS. I also realized I had not built HV=kubevirt for this branch, and I see that get-deps was looking for the non-existent pkg/kernel due to the external-boot-image containing eve-kernel. For the moment I added a no-op pkg/kernel dep. Let me know what you think. @rene adding you on here for an additional set of eyes on my get-deps workaround. |
Fix kubevirt build looking for pkg/kernel dep. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
get-deps-cc
branch
from
0912754 to
8b0faa3
Compare
|
cleaned up spaces at end of lines for yetus |
|
I restarted the failed test, it was a weird AWS issue. |
|
Ugh, I will have to re-approve once the run is successful, as eden tests do not like it until it is. |
|
Eden tests are running now. |
|
There is an eden failure, but it is completely unrelated to this change, so I am ok merging it in. We should resolve that issue, though. |
No description provided.