nodeagent: clarifies reboot reason message #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMART power cycle counter does not expose much and stays same (previous counter and current counter) if system was reset, rebooted or paniced. Previous quite pessimistic reboot message said "kernel crash", which was not always the case and confused our support and customers. More clear message should be "system reset, reboot or kernel panic due to watchdog or kernel bug (no kdump)". Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
rouming
force-pushed
the
clarify-reboot-reason
branch
from
41ce09e to
e401506
Compare
christoph-zededa
approved these changes
Jul 15, 2024
|
This is still confusing "system reset, reboot or kernel panic", which one is it? |
|
We can't tell exactly, unfortunately. We use SMART power cycle counters to make a decision, but what they say is that a machine was powered cycled and this is another message: "device powered off". In all other cases anything can happen from the list I mentioned, the message seems to be more comforting for the user, because it does not insist that this is kernel crash. It might be, yes, but also reset, watchdog, etc. etc. |
milan-zededa
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMART power cycle counter does not expose much and stays same (previous counter and current counter) if system was reset, rebooted or paniced. Previous quite pessimistic reboot message said "kernel crash", which is not always the case and confuses our support and customers. More clear message should be "system reset, reboot or kernel panic due to watchdog or kernel bug (no kdump)".