Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Remove duplicated linuxkit argument #4093

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

rene
Copy link
Contributor

@rene rene commented Jul 17, 2024

This PR fixes the following error when calling 'make cache-export-docker-load':

make IMAGE=docker.io/lfedge/eve-alpine:532dab1b2b14fd49c9e4150246ddc5ccf9e2a3d5 OUTFILE=alpine.tar cache-export-docker-load
Using kernel from KERNEL_TAG=docker.io/lfedge/eve-kernel:eve-kernel-amd64-v6.1.38-generic-fb31ce85306c-gcc 
make cache-export --format docker OUTFILE=/tmp/tmp.4Mu6K7yQ8I && cat /tmp/tmp.4Mu6K7yQ8I | docker load
make: unrecognized option '--format'

The target 'cache-export-docker-load' already calls $(MAKE) cache-export which has the argument included.

This commits fixes the following error when calling
'make cache-export-docker-load':

make IMAGE=docker.io/lfedge/eve-alpine:532dab1b2b14fd49c9e4150246ddc5ccf9e2a3d5 OUTFILE=alpine.tar cache-export-docker-load
Using kernel from KERNEL_TAG=docker.io/lfedge/eve-kernel:eve-kernel-amd64-v6.1.38-generic-fb31ce85306c-gcc
make cache-export --format docker OUTFILE=/tmp/tmp.4Mu6K7yQ8I && cat /tmp/tmp.4Mu6K7yQ8I | docker load
make: unrecognized option '--format'

The target 'cache-export-docker-load' already calls '$(MAKE)
cache-export' which has the argument included.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene rene requested a review from deitch July 17, 2024 14:59
@rene rene requested a review from eriknordmark as a code owner July 17, 2024 14:59
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

@deitch
Copy link
Contributor

deitch commented Jul 17, 2024

Do we really need to wait for all of CI on this one?

@deitch
Copy link
Contributor

deitch commented Jul 17, 2024

Ah shoot. I approved too early, eden tried to run before the other tests were done, and so eden failed. I will restart eden when the other tests are done.

@yash-zededa weren't you working on fixing that?

@yash-zededa
Copy link
Collaborator

Ah shoot. I approved too early, eden tried to run before the other tests were done, and so eden failed. I will restart eden when the other tests are done.

@yash-zededa weren't you working on fixing that?

@deitch Yes, I am working on it along with other workflow enhancements. Unfortunately, there isn't a straightforward approach to follow, but I am testing a solution. I will be raising PRs soon.

@deitch
Copy link
Contributor

deitch commented Jul 17, 2024

Thanks @yash-zededa . In the meantime, I will restart eden tests once the others are done here.

@deitch
Copy link
Contributor

deitch commented Jul 18, 2024

Reran the failed initial eden job, which now succeeds, kicking off the rest of them.

@deitch deitch merged commit b9c076a into lf-edge:master Jul 18, 2024
36 checks passed
@rene rene deleted the fix-makefile branch December 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants