get-deps: Do not build get-deps all the time

[rene]

Move build commands to the proper target in Makefile so get-deps won't get build every time make -C tools/get-deps is called.

[deitch]

@rene I must have misunderstood the makefile. How does this change it? Won't it still get executed with every call in root of eve to make cache-export or make sbom or any other things?

[rene]

@rene I must have misunderstood the makefile. How does this change it? Won't it still get executed with every call in root of eve to make cache-export or make sbom or any other things?

Yes @deitch , but at this time get-deps will be already built and no go commands will be called.... the problem was that the build commands were in the target all, so they were getting called every time make -C tools/get-deps was called... now it should run very fast when the get-deps binary is already present....

[deitch]

Oh, OK, I see.

Still, do we want to run it every time we call the Makefile? Shouldn't we restrict it in the main Makefile just to targets that need it?

[rene]

Oh, OK, I see.

Still, do we want to run it every time we call the Makefile? Shouldn't we restrict it in the main Makefile just to targets that need it?

It runs only to generate get-deps and the pkg-deps.mk file, once both are there, it shouldn't call make get-deps again... I can't reproduce it locally....

[deitch]

can't reproduce it locally

Yeah but try in CI, where each run is in a new VM, and you will see it being rebuilt over and over, even when not needed.

[rene]

can't reproduce it locally

Yeah but try in CI, where each run is in a new VM, and you will see it being rebuilt over and over, even when not needed.

ok, I'm checking, but apart from that, this fix is needed anyways... so the PR is still valid...

[deitch]

Yeah, fair enough. Let's get it in, then. Can you try and address the Makefile too?

[rene]

Updates in this PR:

• Rebase onto master in order to get GH runners updates....

[deitch]

The fix in #4102 isn't good. Do not approve or merge this until we get that fixed.

[deitch]

#4105 is in, I am testing it in #4103. If it is good, you will be able to rebase this. I will post here.

[deitch]

So far, the packages part is working correctly. I cannot report on eve yet, because the test in #4103 is queued up for workers

[deitch]

Yes, it all is looking good. @rene rebase on master please and you should be good to go here.

[deitch]

Tests are running. When they are done, I will kick off eden.

[deitch]

Started eden tests.

I also looked at the logs:

• the cache is doing the right thing per Actions: proper reference to sha instead of ref for cache key #4105 , which is good
• your change in this PR gets rid of most of the extraneous logs for get-deps, so it does its job, which also is good.

[deitch]

Getting some odd eden errors. But at least it is not the pull rate limits! 😁