[11.0 stable] Make table index part of the IP-rule definition. #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When wwan modem is reset by ModemManager (because it is not responsive), the wwan interface is recreated and will get a different interface index. This means that the target routing table index for the port (calculated as 500 + interface index) will change. However, if the IP address assigned by the network is the same after the reset (common in private LTE networks), then only the table index needs to be updated in the corresponding IP rule. But this will be missed because table index is not part of the IP rule definition (SrcIPRule struct) and instead it is calculated on-demand inside the Create/Modify method of the configurator. As a result, there is no change detected by the SrcIPRule.Equal() method between the current and the new intended state, hence Modify method is not called by the reconciler and IP rule is not updated after modem reset. In this commit this is fixed by adding the table ID into the IP rule definition. In theory, this can also affect wlan or eth interface if there is e.g. a driver reset and the interface is recreated (while getting the same IP). However, with cellular modems this is more likely because they are quite flaky and ModemManager resets them when they get stuck. Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit 695652b)
rouming
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4143