Add GH Action to check SPDX license headers in new files. #4166
Conversation
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
2 times, most recently
from
c638549 to
b46fa32
Compare
OhmSpectator
changed the title
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
2 times, most recently
from
0f7974e to
7defec1
Compare
OhmSpectator
changed the title
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
7defec1 to
a283af4
Compare
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
a283af4 to
3467ec6
Compare
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
3467ec6 to
4e1c7e9
Compare
tools/spdx-check.sh
Outdated
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # List of files to check, excluding vendor directories | ||
| files=$(git diff --name-only --diff-filter=A origin/master..HEAD | grep -v "vendor/") |
There was a problem hiding this comment.
I wonder if origin/master..HEAD is going to work for backports (once this script becomes part of some LTS branch).
Maybe we could pass ${{ github.event.pull_request.base.ref }} as an input argument to this script (or github.base_ref, I don't know which one is the correct in this case).
There was a problem hiding this comment.
Yep, good suggestion! I'll change to base.ref
There was a problem hiding this comment.
Looks like he fixed version works
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
4e1c7e9 to
2035698
Compare
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
2035698 to
c9614d8
Compare
|
I want to add .proto files to the list... |
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
c9614d8 to
508937e
Compare
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
2 times, most recently
from
5a231a6 to
9d78904
Compare
|
@rene, could you recheck please? |
Created a workflow to automatically check for SPDX license headers in new files when a PR is opened or changes are pushed to `master` or version-stable branches. Added `tools/spdx-check.sh` script that scans new files with specific extensions and certain filenames for the `SPDX-License-Identifier` header. The script excludes files in `vendor/` directories from the check. The workflow will fail if any of the new files are missing the required SPDX license header. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
OhmSpectator
force-pushed
the
feature/add-spdx-check
branch
from
9d78904 to
e68eca1
Compare
There was a problem hiding this comment.
@OhmSpectator for now it's ok, we do care about Apache 2.0, but please, consider add Apache 2.0 compatible licenses in the future....
@rene, do you find this list fine for it? MIT License: |
masteror version-stable branches.tools/spdx-check.shscript that scans new files with specific extensions and certain filenames for theSPDX-License-Identifierheader.vendor/directories from the check.