Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update_kernel_commits.py #4176

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Aug 28, 2024

If we push a new branch it doesn't exist on dockerhub and the script doesn't throw an error when a commit exists on github but not on dockerhub

now we do it
image

@rucoder rucoder requested a review from deitch as a code owner August 28, 2024 15:47
Copy link
Contributor

@rouming rouming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rucoder rucoder force-pushed the rucoder/kernel-update-fix branch 2 times, most recently from 335e8c7 to 8be0de0 Compare August 28, 2024 15:56
If we push a new branch it doesn't exist on dockerhub and the script
doesn't throw an error when a commit exists on github but not on
dockerhub

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
@rucoder rucoder force-pushed the rucoder/kernel-update-fix branch from 8be0de0 to e727a25 Compare August 28, 2024 15:59
@rucoder rucoder changed the title Fix update_kernel_commits.mk Fix update_kernel_commits.py Aug 28, 2024
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@OhmSpectator OhmSpectator merged commit eb85d5d into lf-edge:master Aug 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants