Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eve api vendor and go mod files #4181

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

zedi-pramodh
Copy link

Bump eve api after the PR lf-edge/eve-api#65

Copy link
Contributor

@naiming-zededa naiming-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since Andrew is almost done w/ the eve-api change, maybe should wait for that.

@OhmSpectator
Copy link
Member

@zedi-pramodh, could you please rebase on the latest master so the new GitHub workflow works correctly?

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zedi-pramodh zedi-pramodh force-pushed the update-eve-api-vendor-files branch from 7278b4f to 4842f47 Compare August 29, 2024 16:52
@zedi-pramodh
Copy link
Author

Amended the commit since eve-api changed again with PR
lf-edge/eve-api#63

@zedi-pramodh
Copy link
Author

@zedi-pramodh, could you please rebase on the latest master so the new GitHub workflow works correctly?

I did rebase yesterday only :) things changed again !!

Need to bump eve-api after following PRs
lf-edge/eve-api#63
lf-edge/eve-api#65

Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
@zedi-pramodh zedi-pramodh force-pushed the update-eve-api-vendor-files branch from 4842f47 to e643ea4 Compare August 29, 2024 17:03
@zedi-pramodh
Copy link
Author

I did rebase yesterday only :) things changed again !!

Rebase done and amended the commit.

Copy link
Contributor

@naiming-zededa naiming-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OhmSpectator
Copy link
Member

Fix the commit message, please =)
https://github.com/lf-edge/eve/actions/runs/10619453990/job/29437072620?pr=4181
Expect that, looks good =)

These are generated vendor files, nothign to see.

Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
@zedi-pramodh zedi-pramodh force-pushed the update-eve-api-vendor-files branch from e643ea4 to 031efd0 Compare August 29, 2024 21:43
@OhmSpectator OhmSpectator merged commit 981f801 into lf-edge:master Aug 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants