-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eve api vendor and go mod files #4181
Update eve api vendor and go mod files #4181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since Andrew is almost done w/ the eve-api change, maybe should wait for that.
@zedi-pramodh, could you please rebase on the latest master so the new GitHub workflow works correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7278b4f
to
4842f47
Compare
Amended the commit since eve-api changed again with PR |
I did rebase yesterday only :) things changed again !! |
Need to bump eve-api after following PRs lf-edge/eve-api#63 lf-edge/eve-api#65 Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
4842f47
to
e643ea4
Compare
Rebase done and amended the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix the commit message, please =) |
These are generated vendor files, nothign to see. Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
e643ea4
to
031efd0
Compare
Bump eve api after the PR lf-edge/eve-api#65