mini-yetus : Improve error reporting #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shjala, could you please rebase it on top of the master? I want to check how the fixes in workflow introduced in another PR behave... |
sure. What happened to eden? it is all red. |
Improve error reporting in mini-yetus.sh script and don't exit if files dosn't exist. Instead, print an error message and continue. This can happen if the current branch is built on top of the source branch but source branch has diverged and some files are not present in the current branch. This changes allow the script to atleast run yetus on the files that do exist in the current branch. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4194 +/- ##
=======================================
Coverage 19.69% 19.69%
=======================================
Files 8 8
Lines 2600 2600
=======================================
Hits 512 512
Misses 1985 1985
Partials 103 103 ☔ View full report in Codecov by Sentry. |
OhmSpectator
approved these changes
Sep 1, 2024
|
@yash-zededa, any ideas about what happens with Eden tests on master? |
Found the issue raising PR to fix it. |
eriknordmark
approved these changes
Sep 1, 2024
|
Waiting for a runner to pick up this job... Already 1 hour... Looks suspicious. |
|
Apologies, closed by mistake. @OhmSpectator the runners were occupied with the lf-edge master run. Few jobs are started now. The issue is fixed now. |
OhmSpectator
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error reporting in mini-yetus.sh script and don't exit if files doesn't exist. Instead, print an error message and continue. This can happen if the current branch is built on top of the source branch but source branch has diverged and some files are not present in the current branch. This changes allow the script to atleast run yetus on the files that do exist in the current branch.