-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0 stable] Update eden to the latest version 0.9.11 #4260
Conversation
Try the latest eden version in the 11.0-stable branch. Currently, most of the test suites are failing on that branch and are therefore pretty much useless. Signed-off-by: Milan Lenco <milan@zededa.com> (cherry picked from commit b283541)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test it
We will have to come back to this tomorrow since we have reached dockerhub pull limits. |
|
This is failing because eden is testing feature that was developed after 11.0 |
Looks complicated =( But, in general, it would be nice to understand how we deal with Eden from the maintainability perspective. Do we duplicate the LTS branches logic there as well? How do we backport? I think using the same approach as the main EVE repo would make sense... |
Because of backward incompatibility we maintained stable branches on eden , as you can see in change you're switching from 0.9.3-stable to 0.9.11, 0.9.3-stable is a branch in eden, where you can cherry-pick changes of eden tests, so that they can reflex backport fixes without creating the problem. Ideally, we need to keep a table somewhere (question is where) where we map EVE version to Eden, so far what I've been doing is specifying EVE version in each Eden release, in release notes. You can see those here I'd suggest we create either md file called MAINTAINING.md or a GitHub wiki page describing this process :) and mention them in PR template and/or issue template @OhmSpectator hope that answers your question :) |
The problem is that 0.9.3-stable is not stable at all. Tests are failing miserably. The set of commits we would need to backport to make that version useful is pretty long. At the same time, the test that Paul added for writing files to containers from cloud-init config (which 11.0 does not yet support) is already in eden 0.9.5, before the commits stabilizing eden tests came in. So I do not really know how to deal with this situation. |
Well, we can put proper process in place moving forward. But can we use 0.9.4, or stabilizing came in 0.9.5 ? And how hard would be cherry-picking stabilizing commits to 0.9.3-stable? |
@uncleDecart, any ideas on how to proceed with the PR?.. |
We need to branch out from 0.9.11 revert commits which create tests that are not supported by this EVE version. We can talk about this Monday if you like :) |
Closing until we have eden branch suitable for EVE 11.0 |
Try the latest eden version in the 11.0-stable branch. Currently, most of the test suites are failing on that branch and are therefore pretty much useless.
Signed-off-by: Milan Lenco milan@zededa.com
(cherry picked from commit b283541)