Switch to v4 of actions/cache; add documentation about it; explicitly check runner arch. #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check runner arch. Does the following three things in one file: 1. Switch to v4 of actions/cache. That action has a nasty bug in that it depends on the absolute path to the directory being cached. That means that if you save on one runner type and restore on another, it will fail the restore. Not 100% clear that v4 fixes it. 2. Add documentation about why we use actions/cache in the way we do, rather than separate actions/cache/save. 3. For `eve` job, we would assume the runner is amd64, which will not hold forever. Instead, explicitly check it. Signed-off-by: Avi Deitcher <avi@deitcher.net>
deitch
force-pushed
the
cache-cross-runners
branch
from
9a6f99d to
a2dfdfa
Compare
uncleDecart
reviewed
Sep 24, 2024
OhmSpectator
approved these changes
Sep 24, 2024
|
Let's try to merge and see if it helps for other PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the following three things in one file:
evejob, we would assume the runner is amd64, which will not hold forever. Instead, explicitly check it.I also added some logging output, to be sure these changes take correctly.
If v4 does not solve it, we may need to take some more manual steps, which I prefer not.