-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/pillar: make ioBundleError deepcopy-able #4295
pkg/pillar: make ioBundleError deepcopy-able #4295
Conversation
59a3cae
to
257c12c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4295 +/- ##
==========================================
- Coverage 21.05% 20.93% -0.13%
==========================================
Files 13 13
Lines 2878 2895 +17
==========================================
Hits 606 606
- Misses 2146 2163 +17
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve to trigger the Eden tests
Eden output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understandable.
257c12c
to
2c497b7
Compare
2c497b7
to
c9d550d
Compare
error types very often have private members that cannot be marshalled with `json.Marshal` we fix this by only storing the error type and the error string (err.Error()) as values in uppercase members of our own ioBundleError type log output: ``` json Unmarshal in deepCopy: json: cannot unmarshal object into Go struct field IoBundleError.IoBundleList.Error.Errors of type error ``` introduced by d1e13b8 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
c9d550d
to
d676103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run eden again
error types very often have private members that cannot be marshalled with
json.Marshal
we fix this by only storing the error type and the error string (err.Error()) as values in uppercase members of our own ioBundleError type
log output:
introduced by d1e13b8