remove reference to unused verification from github workflows #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A prior commit removed the separate verification image and integrated it into installer. This removes a call to that make target from the publish.yml workflow, and updates the CODEOWNERS to reference the correct ones. Signed-off-by: Avi Deitcher <avi@deitcher.net>
OhmSpectator
approved these changes
Sep 26, 2024
uncleDecart
approved these changes
Sep 26, 2024
|
I have been wondering about that. Should our workflows be subject to dealing with branches and backports? Or should we have perhaps a separate repo - or branch - dedicated solely to workflows, which the other branches all just reference? |
|
@deitch. @uncleDecart I think right now we have the only solution of backporting to the -stable branches. Later, we can think about how to make it easier. Read about the best practices, etc... |
|
@deitch @uncleDecart I created an issue to track it: #4297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prior commit removed the separate verification image and integrated it into installer. This removes a call to that make target from the publish.yml workflow, and updates the CODEOWNERS to reference the correct ones.