Do not try to decrypt empty wwan cipher data #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when username/password credentials are not used for cellular connection, zedagent still tries to decrypt the cipher block which in this case will contain empty CipherData. This results in error "block contains incomplete data" being reported inside the DeviceNetworkStatus for the cellular port. Even though EVE will not end up publishing this to the controller (because mmagent will not try to use CipherBlockStatus unless user auth is enabled), we should still fix this to avoid confusing error inside the DeviceNetworkStatus pubsub message. Signed-off-by: Milan Lenco <milan@zededa.com>
OhmSpectator
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when username/password credentials are not used for cellular connection, zedagent still tries to decrypt the cipher block which in this case will contain empty
CipherData. This results in errorblock contains incomplete databeing reported inside theDeviceNetworkStatusfor the cellular port (inWirelessCfg). Even though EVE will not end up publishing this to the controller (because mmagent will not try to useCipherBlockStatusunless user auth is enabled), we should still fix this to avoid confusing error inside theDeviceNetworkStatuspubsub message.