-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance scripts and Makefile targets for RC and LTS release support #4323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-zededa
changed the title
feat: Add scripts and Makefile targets for RC and LTS releases
[WIP] feat: Add scripts and Makefile targets for RC and LTS releases
Oct 7, 2024
yash-zededa
changed the title
[WIP] feat: Add scripts and Makefile targets for RC and LTS releases
Add scripts and Makefile targets for RC and LTS releases
Oct 7, 2024
yash-zededa
changed the title
Add scripts and Makefile targets for RC and LTS releases
Enhance scripts and Makefile targets for RC and LTS release support
Oct 7, 2024
rene
reviewed
Oct 8, 2024
rene
reviewed
Oct 8, 2024
yash-zededa
changed the title
Enhance scripts and Makefile targets for RC and LTS release support
[WIP] Enhance scripts and Makefile targets for RC and LTS release support
Oct 8, 2024
eriknordmark
reviewed
Oct 9, 2024
eriknordmark
reviewed
Oct 9, 2024
eriknordmark
reviewed
Oct 9, 2024
eriknordmark
reviewed
Oct 9, 2024
yash-zededa
changed the title
[WIP] Enhance scripts and Makefile targets for RC and LTS release support
Enhance scripts and Makefile targets for RC and LTS release support
Oct 10, 2024
feat: Add scripts and Makefile targets for RC and LTS releases In accordance with the testing team's requirement to create a release candidate (RC) before releasing the LTS version of Eve for certification. These scripts automate the creation of RC and LTS releases by calculating the version number based on the latest tag and incrementing it accordingly. Signed-off-by: yash-zededa <yash@zededa.com>
eriknordmark
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the testing team's requirement to create a release candidate (RC) before releasing the LTS version of EVE for certification(i.e release approved by the testing team).
These scripts automate the creation of RC and LTS releases by calculating the version number based on the latest tag and incrementing it accordingly.
We have removed the old patch make targets and added two new ones:
rc-release
andlts-release
.The
rc-release
command triggers a shell script that generates anrc
tag based on the latest tag available for the branch.For example:
If the latest tag for branch
13.4
is13.4.0
, running themake rc-release
command will create a release candidate (RC) tag:Once the testing team approves the release, we will create the corresponding LTS release, e.g.,
13.4.0-lts
.Note: Since this is the first release from the branch, the LTS version will start at
0
. For subsequent releases, the version number will increment accordingly:13.4.0-rc1
→13.4.0-rcn
→ TEST_TEAM (Green) →13.4.0-lts
13.4.0-lts
→13.4.1-rc1
→13.4.1-rcn
→ TEST_TEAM (Green) →13.4.1-lts
The
make lts-release
command will take the latestrc
tag and create an LTS release.For example:
13.4-stable
branch is13.4.1-rc3
, the LTS tag would be13.4.1-lts
.O/P's:
I have made every effort to cover all relevant use cases. However, if anything has been overlooked or is missing, please feel free to let me know :)