Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance scripts and Makefile targets for RC and LTS release support #4323

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Enhance scripts and Makefile targets for RC and LTS release support #4323

merged 1 commit into from
Oct 10, 2024

Conversation

yash-zededa
Copy link
Collaborator

@yash-zededa yash-zededa commented Oct 7, 2024

In accordance with the testing team's requirement to create a release candidate (RC) before releasing the LTS version of EVE for certification(i.e release approved by the testing team).

These scripts automate the creation of RC and LTS releases by calculating the version number based on the latest tag and incrementing it accordingly.

We have removed the old patch make targets and added two new ones: rc-release and lts-release.

The rc-release command triggers a shell script that generates an rc tag based on the latest tag available for the branch.

For example:

  • If the latest tag for branch 13.4 is 13.4.0, running the make rc-release command will create a release candidate (RC) tag:

    Creating RC release: '13.4.0-rc1'
    Tagged new version: 13.4.0-rc1. Please push the tag to the remote repository:
    git push origin 13.4.0-rc1
    

Once the testing team approves the release, we will create the corresponding LTS release, e.g., 13.4.0-lts.

Note: Since this is the first release from the branch, the LTS version will start at 0. For subsequent releases, the version number will increment accordingly:

  • 13.4.0-rc113.4.0-rcn → TEST_TEAM (Green) → 13.4.0-lts
  • 13.4.0-lts13.4.1-rc113.4.1-rcn → TEST_TEAM (Green) → 13.4.1-lts

The make lts-release command will take the latest rc tag and create an LTS release.

For example:

  • If the last RC tag for the 13.4-stable branch is 13.4.1-rc3, the LTS tag would be 13.4.1-lts.

O/P's:

bash-3.2$ make rc-release
Creating RC release: '13.4.0-rc1'
Tagged new version: 13.4.0-rc1. Please push the tag to the remote repository
git push origin 13.4.0-rc1
bash-3.2$ make rc-release
Creating RC release: '13.4.0-rc2'
Tagged new version: 13.4.0-rc2. Please push the tag to the remote repository
git push origin 13.4.0-rc2
bash-3.2$ make lts-release
Creating the first LTS release: 13.4.0-lts
Tagged new version: 13.4.0-lts. Please push the tag to the remote repository
git push origin 13.4.0-lts

I have made every effort to cover all relevant use cases. However, if anything has been overlooked or is missing, please feel free to let me know :)

@yash-zededa yash-zededa changed the title feat: Add scripts and Makefile targets for RC and LTS releases [WIP] feat: Add scripts and Makefile targets for RC and LTS releases Oct 7, 2024
@yash-zededa yash-zededa changed the title [WIP] feat: Add scripts and Makefile targets for RC and LTS releases Add scripts and Makefile targets for RC and LTS releases Oct 7, 2024
@yash-zededa yash-zededa changed the title Add scripts and Makefile targets for RC and LTS releases Enhance scripts and Makefile targets for RC and LTS release support Oct 7, 2024
@yash-zededa yash-zededa marked this pull request as ready for review October 7, 2024 20:13
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@github-actions github-actions bot requested a review from uncleDecart October 8, 2024 14:05
@yash-zededa yash-zededa changed the title Enhance scripts and Makefile targets for RC and LTS release support [WIP] Enhance scripts and Makefile targets for RC and LTS release support Oct 8, 2024
@yash-zededa yash-zededa marked this pull request as draft October 8, 2024 14:06
Makefile Outdated Show resolved Hide resolved
tools/lts-release.sh Outdated Show resolved Hide resolved
tools/rc-release.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from eriknordmark October 10, 2024 09:01
@yash-zededa yash-zededa changed the title [WIP] Enhance scripts and Makefile targets for RC and LTS release support Enhance scripts and Makefile targets for RC and LTS release support Oct 10, 2024
@yash-zededa yash-zededa marked this pull request as ready for review October 10, 2024 09:40
@OhmSpectator OhmSpectator added the stable Should be backported to stable release(s) label Oct 10, 2024
tools/lts-release.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from eriknordmark October 10, 2024 14:47
feat: Add scripts and Makefile targets for RC and LTS releases

In accordance with the testing team's requirement to create a release
candidate (RC) before releasing the LTS version of Eve for certification.

These scripts automate the creation of RC and LTS releases by calculating
the version number based on the latest tag and incrementing it accordingly.

Signed-off-by: yash-zededa <yash@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable Should be backported to stable release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants