Reduce VTPM container size #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rucoder
force-pushed
the
rucoder/vtpm-size
branch
from
32d7f61 to
2d3d4c3
Compare
pkg/vtpm/Dockerfile
Outdated
| @@ -19,6 +19,7 @@ RUN ./autogen.sh --prefix=/usr --with-tpm2 | |||
| RUN make -j$(nproc) | |||
| RUN make -j$(nproc) install | |||
| RUN cp /usr/lib/libtpms.so.* /out/usr/lib/ | |||
| RUN strip /out/usr/lib/libtpms.so.* | |||
There was a problem hiding this comment.
Suggested change
| RUN strip /out/usr/lib/libtpms.so.* | |
| RUN strip --strip-unneeded /out/usr/lib/libtpms.so.* |
as of https://www.linuxfromscratch.org/lfs/view/development/chapter08/stripping.html
There was a problem hiding this comment.
@christoph-zededa this is a default behavior but I'll commit it to be on a safe side
- strip SO libraries - do not copy *.a and *.la static libraries - fix ENV syntax to match the latest Dockerfile spec Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
rucoder
force-pushed
the
rucoder/vtpm-size
branch
from
2d3d4c3 to
d48fa29
Compare
|
LGTM, even though it should not affect anything, but let me run aziot tests and make sure everything remains functional. |
3 tasks
|
Tested the following :
all green. |
@shjala could you approve the PR then? |
shjala
approved these changes
Oct 8, 2024
OhmSpectator
approved these changes
Oct 8, 2024
|
We can do here: Line 65 in d48fa29 as well I guess? |
| @@ -47,6 +50,7 @@ RUN ./bootstrap && \ | |||
| make -j$(nproc) | |||
| RUN cp lib/.libs/libcommon.so* /out/usr/lib/ | |||
| RUN cp tools/.libs/tpm2 /out/usr/bin/ | |||
| RUN strip --strip-unneeded /out/usr/lib/*.so* | |||
There was a problem hiding this comment.
Could we strip the tmp2 bin as well here?
Suggested change
| RUN strip --strip-unneeded /out/usr/lib/*.so* | |
| RUN strip --strip-unneeded /out/usr/lib/*.so* | |
| RUN strip --strip-unneeded /out/usr/bin/tpm2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of resulting rootfs image is reduced by
2 555 904bytes (1%)