Include ZFS in installer #4362
Merged
Include ZFS in installer #4362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for ZFS vault, HV=kubevirt Signed-off-by: Andrew Durbin <andrewd@zededa.com>
OhmSpectator
approved these changes
Oct 16, 2024
|
I assume this needs to be backported to 13.4-stable, so I added the stable label. |
|
Ok, once merging I'll submit the cherry-pick back port. |
|
@eriknordmark, should we really wait for all the Eden tests here? Eden tests do not touch the functionality changed here, as far as I understand. |
|
The Eden tests do go through the onboarding process and it's useful to sanity check that. I thought there were tests running the installer image as well, but clearly not with zfs since then we wouldn't have had this regression. |
wow, I didn't know... I have at least to find what are the test cases that we run)) |
|
All green! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for ZFS vault, HV=kubevirt