-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial set of pillar types related files for cluster multi-node mode #4387
Merged
eriknordmark
merged 1 commit into
lf-edge:master
from
naiming-zededa:naiming-pillar-types
Oct 29, 2024
Merged
Initial set of pillar types related files for cluster multi-node mode #4387
eriknordmark
merged 1 commit into
lf-edge:master
from
naiming-zededa:naiming-pillar-types
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naiming-zededa
commented
Oct 19, 2024
- for cluster multi-node mode, some of the initial pillar side types related files, additional changes will be added in later PRs
naiming-zededa
changed the title
Initial set of pillar types related files
Initial set of pillar types related files for cluster multi-node mode
Oct 19, 2024
naiming-zededa
force-pushed
the
naiming-pillar-types
branch
4 times, most recently
from
October 19, 2024 02:59
316b999
to
9cd4222
Compare
- for cluster multi-node mode, some of the initial pillar side types related files, additional changes will be added in later PRs Signed-off-by: Naiming Shen <naiming@zededa.com>
naiming-zededa
force-pushed
the
naiming-pillar-types
branch
from
October 21, 2024 18:22
9cd4222
to
4890f4e
Compare
milan-zededa
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments have been addressed
@eriknordmark can we merge this in and we will have other cluster related PRs depends on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.