Add monitor application to EVE #4410

rucoder · 2024-10-31T14:58:44Z

UPDATE: all comments were fixed. Remaining 3 tasks will be converted into issues and fixed later
UPDATE 2: fixed last comments from @eriknordmark.

This PR introduces a monitor agent to communicate with rust application that implements a TUI (TextUI) and allows the user to monitor system status and perform (as of now) two operaions:

Change IP address of Ethernet interface (DHCP <-> static)
Set server URL if the node is not yet onboarded

The monitor agent opens a Unix socket and waits for incoming connection. When the connection is established the NodeStatus structure is sent to the other party to provide current node status. Then other information is sent periodically as soon as it become available in PubSub

Current limitations/issues

network: yes is used in build.yaml while we are working on proper source vendoring approach for rust application
there is no way to completely remove manual DPC from the list
EVE structures should not be sent as-is to Rust. Every time the structure is changed on Eve side there is no way to catch this situation at build time. Stable EVE-Rust API is needed.
define git commit SHA in Dockerfile when Fix SetDPC request and implement SetServer request and UI eve-monitor-rs#3 is merged
write a documentation in pkg/pillar/docs/monitor.md

pkg/pillar/cmd/nim/nim.go

codecov · 2024-10-31T15:20:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.93%. Comparing base (dd27fe1) to head (4734622).
Report is 20 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4410   +/-   ##
=======================================
  Coverage   20.93%   20.93%           
=======================================
  Files          13       13           
  Lines        2895     2895           
=======================================
  Hits          606      606           
  Misses       2163     2163           
  Partials      126      126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

milan-zededa · 2024-10-31T15:21:07Z

pkg/pillar/cmd/nim/nim.go

 	lastResort         *types.DevicePortConfig
+	manualDPC          *types.DevicePortConfig


It seems that forceManualDPC and manualDPC are unused?

@milan-zededa this was a placeholder to implement merging of DPCs, not it is done on rust side but I do not like to have so many dependencies on eve types. I'll remove it for now

milan-zededa · 2024-10-31T15:22:00Z

pkg/pillar/cmd/nim/nim.go

@@ -782,6 +809,12 @@ func (n *nim) handleDPCImpl(key string, configArg interface{}, fromFile bool) {
 		n.forceLastResort = false
 		n.reevaluateLastResortDPC()
 	}
+	// if device can connect to controller it may get a new DPC in global config. This global DPC
+	// will have higher priority but can be invalid and the device will loose connectifity again
+	// at least temporraraly while DPC is beeing tested. To avoid this we reset the timestamp on


temporraraly -> temporarily

(and connectifity in the line above)

milan-zededa · 2024-10-31T15:22:55Z

pkg/pillar/cmd/monitor/subsriptions.go

@@ -0,0 +1,444 @@
+// Copyright (c) 2024 Zededa, Inc.


Typo in the filename

OhmSpectator · 2024-10-31T15:34:29Z

pkg/monitor/Dockerfile

+RUN cp /app/target/$CARGO_BUILD_TARGET/release/monitor /app/target/
+
+
+FROM lfedge/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726 AS runtime


We use 591df01e581889c3027514c8a91feaca1c8ad49f now.

@OhmSpectator yeah, CI told me that. I'll fix.

christoph-zededa · 2024-10-31T16:02:18Z

pkg/pillar/cmd/monitor/messages.go

+	nodeStatus.ZedAgentStatus = ctx.getZedAgentStatus()
+	nodeStatus.AppSummary = ctx.getAppSummary()
+
+	if ctx.lastNodeStatus != nil && *ctx.lastNodeStatus == nodeStatus {


Is there a reason behind this check?

@christoph-zededa I have a plan to reuse this function to send a node stats to abstract types used in EVE from types used in Go-Rust interface

christoph-zededa · 2024-10-31T16:03:42Z

pkg/pillar/cmd/monitor/messages.go

+	if item, err := sub.Get("global"); err == nil {
+		zedAgentStatus := item.(types.ZedAgentStatus)
+		return zedAgentStatus
+	}


IMO the error should be logged

christoph-zededa · 2024-10-31T16:04:15Z

pkg/pillar/cmd/monitor/monitor.go

+var logger *logrus.Logger
+var log *base.LogObject
+
+type monitorContext struct {


Suggested change

type monitorContext struct {

type monitor struct {

It is not a context, is it?

@christoph-zededa we call the field in SubscriptionOptions Ctx aka context, and the type is typically "$agent"Context.

Sure, this is not the golang context.Context. But there is more than one kind of context; which one you refer to depends on your context ;-)

I would side with Christoph on this one, I think it is cleaner (and Go-Idiomatic) to just call it monitor. I haven't see this <something>Context terminology used with custom structs in any other Go project.

@eriknordmark @milan-zededa @christoph-zededa so, which one should I use? I have no personal preferences but as Erik mentioned we use this style all over EVE

NIM, zedrouter, mmagent and their components no longer use the Context suffix. I think it reads better and avoids confusion with context.Context

renamed to 'monitor'

christoph-zededa · 2024-10-31T16:05:12Z

pkg/pillar/cmd/monitor/monitor.go

+	if _, err := os.Stat(types.ServerFileName); os.IsNotExist(err) {
+		ctx.serverNameAndPort = ""
+		return nil
+	}


TOCTOU

better to just check if err from os.Readfile is an ENOENT

os.IsNotExist is the golang way to check this AFAIK.

https://pkg.go.dev/os#IsNotExist

This function predates errors.Is. It only supports errors returned by the os package. New code should use errors.Is(err, fs.ErrNotExist).

good that we talked about it :-)

christoph-zededa · 2024-10-31T16:07:12Z

pkg/pillar/cmd/monitor/monitor.go

+	findCmd := exec.Command("/sbin/findfs", "PARTLABEL=CONFIG")
+	deviceBytes, err := findCmd.Output()
+	if err != nil {
+		return fmt.Errorf("failed to find CONFIG partition: %v", err)


Suggested change

return fmt.Errorf("failed to find CONFIG partition: %v", err)

return fmt.Errorf("failed to find CONFIG partition: %v -- output was: %s", err, string(deviceBytes))

christoph-zededa · 2024-10-31T16:08:10Z

pkg/pillar/cmd/monitor/monitor.go

+	// 3. Mount the CONFIG partition as read-write
+	mountCmd := exec.Command("mount", "-t", "vfat", "-o", "rw,iocharset=iso8859-1", devicePath, tempDir)
+	if err := mountCmd.Run(); err != nil {
+		return fmt.Errorf("failed to mount CONFIG partition: %v", err)


please include the stdout/stderr of mount in the error message.

christoph-zededa · 2024-10-31T16:08:41Z

pkg/pillar/cmd/monitor/monitor.go

+	if err := mountCmd.Run(); err != nil {
+		return fmt.Errorf("failed to mount CONFIG partition: %v", err)
+	}
+	defer exec.Command("umount", tempDir).Run()


please check for errors

christoph-zededa · 2024-10-31T16:11:45Z

pkg/pillar/cmd/monitor/subsriptions.go

+			Ctx:           ctx,
+			CreateHandler: handleDPCCreate,
+			ModifyHandler: handleDPCModify,
+			DeleteHandler: handleDPCDelete,


Why does this one not have ErrorTime set?

christoph-zededa · 2024-10-31T16:12:59Z

pkg/pillar/cmd/monitor/subsriptions.go

+
+	subDevicePortConfigList, err := ps.NewSubscription(
+		pubsub.SubscriptionOptions{
+			AgentName:     "nim",
+			MyAgentName:   agentName,
+			Persistent:    true,
+			TopicImpl:     types.DevicePortConfigList{},
+			Activate:      false,
+			Ctx:           ctx,
+			CreateHandler: handleDPCCreate,
+			ModifyHandler: handleDPCModify,
+			DeleteHandler: handleDPCDelete,
+		})
+	if err != nil {
+		log.Error("Cannot create subscription for DevicePortConfigList")
+		return err
+	}
+
+	subAppInstanceSummary, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "zedmanager",
+		MyAgentName:   agentName,
+		TopicImpl:     types.AppInstanceSummary{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleAppInstanceSummaryCreate,
+		ModifyHandler: handleAppInstanceSummaryModify,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for AppInstanceSummary")
+		return err
+	}
+
+	subAppInstanceStatus, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "zedmanager",
+		MyAgentName:   agentName,
+		TopicImpl:     types.AppInstanceStatus{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleAppInstanceStatusCreate,
+		ModifyHandler: handleAppInstanceStatusModify,
+		DeleteHandler: handleAppInstanceStatusDelete,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for AppInstanceStatus")
+		return err
+	}
+
+	subDownloaderStatus, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "downloader",
+		MyAgentName:   agentName,
+		TopicImpl:     types.DownloaderStatus{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleDownloaderStatusCreate,
+		ModifyHandler: handleDownloaderStatusModify,
+		DeleteHandler: handleDownloaderStatusDelete,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for DownloaderStatus")
+		return err
+	}
+
+	subLedBlinkCounter, err := ps.NewSubscription(
+		pubsub.SubscriptionOptions{
+			AgentName:     "",
+			MyAgentName:   agentName,
+			TopicImpl:     types.LedBlinkCounter{},
+			Activate:      false,
+			Ctx:           ctx,
+			CreateHandler: handleLedBlinkCreate,
+			ModifyHandler: handleLedBlinkModify,
+			WarningTime:   warningTime,
+			ErrorTime:     errorTime,
+		})
+	if err != nil {
+		log.Error("Cannot create subscription for LedBlinkCounter")
+		return err
+	}
+
+	subZedAgentStatus, err := ps.NewSubscription(pubsub.SubscriptionOptions{
+		AgentName:     "zedagent",
+		MyAgentName:   agentName,
+		TopicImpl:     types.ZedAgentStatus{},
+		Activate:      false,
+		Ctx:           ctx,
+		CreateHandler: handleZedAgentStatusCreate,
+		ModifyHandler: handleZedAgentStatusModify,
+		WarningTime:   warningTime,
+		ErrorTime:     errorTime,
+	})
+	if err != nil {
+		log.Error("Cannot create subscription for ZedAgentStatus")
+		return err
+	}


christoph-zededa · 2024-10-31T16:17:11Z

pkg/pillar/cmd/monitor/ipc_server.go

+	clientConnected chan bool
+}
+
+// constructor


Suggested change

// constructor

// factory method

christoph-zededa · 2024-10-31T16:19:46Z

pkg/pillar/cmd/monitor/ipc_server.go

+		ipcMessage := IpcMessage{Type: t, Message: json.RawMessage(data)}
+		if data, err = json.Marshal(ipcMessage); err == nil {
+			log.Noticef("Sending IPC message: %s", string(data))
+			_, err = s.codec.Write(data)


please wrap the error so that the reader of the log can see later which function the error came from

christoph-zededa · 2024-10-31T16:21:53Z

pkg/pillar/cmd/monitor/ipc_server.go

+		if err := json.Unmarshal(r.RequestData, &dpc); err == nil {
+			if err := ctx.IPCServer.validateDPC(dpc); err != nil {
+				return r.errResponse("Failed to validate DPC", err)
+			}
+			// unpublish current manual DPC first
+			ctx.pubDevicePortConfig.Unpublish(dpc.Key)
+			// publish the DPC
+			if err := ctx.pubDevicePortConfig.Publish(dpc.Key, dpc); err != nil {
+				return r.errResponse("Failed to publish DPC", err)
+			} else {
+				return r.okResponse()
+			}
+		} else {
+			return r.malformedRequestResponse(err)
+		}
+	case "SetServer":
+		var server string
+		if err := json.Unmarshal(r.RequestData, &server); err == nil {
+			if err := ctx.updateServerFile(server); err != nil {
+				return r.errResponse("Failed to update server file", err)
+			} else {
+				return r.okResponse()
+			}
+		} else {
+			return r.malformedRequestResponse(err)
+		}


sometimes you check if err != nil and then have an else case, sometimes you check if err == nil and then have an else case

@christoph-zededa why is this bad?

I am just wondering what is the reason behind it.

The "bad" thing is that it is deeply nested.

Suggested change

if err := json.Unmarshal(r.RequestData, &dpc); err == nil {

if err := ctx.IPCServer.validateDPC(dpc); err != nil {

return r.errResponse("Failed to validate DPC", err)

}

// unpublish current manual DPC first

ctx.pubDevicePortConfig.Unpublish(dpc.Key)

// publish the DPC

if err := ctx.pubDevicePortConfig.Publish(dpc.Key, dpc); err != nil {

return r.errResponse("Failed to publish DPC", err)

} else {

return r.okResponse()

}

} else {

return r.malformedRequestResponse(err)

}

case "SetServer":

var server string

if err := json.Unmarshal(r.RequestData, &server); err == nil {

if err := ctx.updateServerFile(server); err != nil {

return r.errResponse("Failed to update server file", err)

} else {

return r.okResponse()

}

} else {

return r.malformedRequestResponse(err)

}

if err := json.Unmarshal(r.RequestData, &dpc); err != nil {

return r.malformedRequestResponse(err)

}

if err := ctx.IPCServer.validateDPC(dpc); err != nil {

return r.errResponse("Failed to validate DPC", err)

}

// unpublish current manual DPC first

ctx.pubDevicePortConfig.Unpublish(dpc.Key)

// publish the DPC

if err := ctx.pubDevicePortConfig.Publish(dpc.Key, dpc); err != nil {

return r.errResponse("Failed to publish DPC", err)

}

return r.okResponse()

case "SetServer":

var server string

if err := json.Unmarshal(r.RequestData, &server); err != nil {

return r.malformedRequestResponse(err)

}

if err := ctx.updateServerFile(server); err != nil {

return r.errResponse("Failed to update server file", err)

}

return r.okResponse()

christoph-zededa · 2024-10-31T16:22:59Z

pkg/pillar/cmd/monitor/ipc_server.go

+			log.Notice("Accepted connection")
+
+			if err != nil {
+				log.Warnf("Accept for RPC call failed: %v", err)
+				continue
+			}


Suggested change

log.Notice("Accepted connection")

if err != nil {

log.Warnf("Accept for RPC call failed: %v", err)

continue

}

if err != nil {

log.Warnf("Accept for RPC call failed: %v", err)

continue

}

log.Notice("Accepted connection")

eriknordmark

It would be good to add a markdown file in pkg/pillar/docs/monitor.md which describes the relationship between the code inside pillar/zedbox and the rust code.

christoph-zededa · 2024-10-31T16:49:27Z

pkg/monitor/Dockerfile

+
+# building the final image
+FROM toolchain AS builder
+ADD --keep-git-dir=true https://github.com/lf-edge/eve-monitor-rs.git /app


Did somebody review this code?

Not the entire code, but there is at least one PR to be reviewed: lf-edge/eve-monitor-rs#3

Before this commit PCR indexes were present only in error text. Add them to VaultStatus to simplify further analysis Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- The monitor agent establishes a connection over Unix socket and send messages to rust application about the system state. - It handles two requests: SetDPC to set new configuration for networking interfaces and SetServer to change the contents of /config/server file Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- the monitor agent depends on a module to parse binary stream from Unix socket in predefined format Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- The application itself is hosted at https://github.com/lf-edge/eve-monitor-rs - The container is built using lfedge/eve-rust:1.80.1 base image and uses cross-compilation - RISCV target is not yet supported - cargo-chef is used to speedup development. It won't speedup CI when --no-cache is used for building - SBOM is generated using cargo-sbom Brief design description 1. The container is started on /dev/tty3 using openvt and not started on any other consoles including SSH and serial consoles. It is intended to be used only by a local operator 2. Full dmesg output is disabled and only panic output is enabled. Full dmesg output is available in the application 3. Standard keymap is changed to support CTRL+left|right|up|down key combinations Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

/dev/console ins the current console for kernel so even when we switch to /dev/tty3 messages still appear and corrupt monitor application. Fo now print them on /dev/tty which is the default kernel tty. TODO: 1. diag output must appear on /dev/ttyS* if defined in the list of kernel consoles 2. The same applies to other subsystems In order to do so the kernel command line must be parsed and the last console= must be detected. Unfortunately there is no easier way to do this Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

christoph-zededa · 2024-11-25T13:46:38Z

pkg/pillar/cmd/monitor/subscriptions.go

+}
+
+func handleDownloaderStatusDelete(ctxArg interface{}, key string,
+	statusArg interface{}) {


What is this function for?

What is this function for?

@christoph-zededa It seems I have to handle it to inform UI that downloading is over. It is empty for now because I do not display the status (only in debug tab which is not visible in production build).

ah okay, so this is wip?

@christoph-zededa yes, it is a WIP and will be fixed in coming PRs

eriknordmark · 2024-11-26T03:49:48Z

pkg/pillar/dpcmanager/dpc.go

@@ -320,7 +326,7 @@ func (m *DpcManager) compressDPCL() {
 				i, dpc)
 		} else {
 			// Retain the lastresort if enabled. Delete everything else.
-			if dpc.Key == LastResortKey && m.enableLastResort {
+			if (dpc.Key == LastResortKey && m.enableLastResort) || (dpc.Key == ManualDPCKey) {
 				m.Log.Tracef("compressDPCL: Retaining last resort. i = %d, dpc: %+v",


trace text doesn't capture the manual case. Maybe saying "manual or last resort"?

eriknordmark · 2024-11-26T03:51:48Z

pkg/pillar/dpcmanager/dpc.go

 // Remove by matching TimePriority and Key
-func (m *DpcManager) removeDPC(dpc types.DevicePortConfig) {
+func (m *DpcManager) removeDPC(dpc types.DevicePortConfig, keyOnly bool) {


I think it would be more clear to introduce a separate removeDPCByKey(key string) function. Furthermore, that function should not log an error if none found since that will happen the first time a manual DPC is added.

eriknordmark · 2024-11-26T05:19:59Z

docs/LOCAL-TUI.md

+
+  These limitations can be relaxed by using a custom font with 256 glyphs comparing to the standard one that uses 512 glyphs. In this case an extra bit can be used to render 16 colors. Besides extra pseudo-graphics glyphs can be added instead of unused characters to display e.g. rounded boxes.
+
+  As of now a standard font is used so the look of the application on the host and on EVE is deferent


deferent or different?

Fixed this one and several other mistakes e.g missed articles. @eriknordmark would it make sense to add more advanced linters to check grammar/spelling of the *.md files?

- 'manual' DPC has highest priority and applied immediately - there can be only one 'manual' DPC. so we nedd to delete all backup copies of it from a DPC list. EVE should not care about previous attempts to change network configuration Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- monitor app is run only on physical monitor so we need to run QEMU with -vga or similar to see it Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- Setting server URL in both /config/server and real config partition Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- Add comments for SubscriptionOptions.{WarningTime, ErrorTime} fields Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- add documentation for pkg/monitor container - update NIM documentation - add documentation for pkg/pillar/cmd/monitor service Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

- Update tag to v0.1.1 which fixes is_onboarded() logic Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

pkg/pillar/cmd/nim/nim.go

milan-zededa · 2024-11-26T19:13:30Z

pkg/pillar/cmd/nim/nim.go

+	// at least temporarily while DPC is being tested. To avoid this we reset the timestamp on
+	// the Manual DPC to the current time
+	// TODO: do it. or check for ManualDPCKey in DPCManager
+	// TODO 2: we should not try lastresort DPC if the user set the DPC to manual


Is this PR ready for review&merge despite these two TODOs?

@milan-zededa I hope yes. It addresses immediate chicken and egg problem with incorrect global network configuration. I can remove the comment

eriknordmark

LGTM

christoph-zededa · 2024-11-27T15:43:26Z

pkg/pillar/cmd/monitor/monitor.go

+		return fmt.Errorf("failed to update shadow copy: %v", err)
+	}
+
+	if remountErr != nil {


this is always false, isn't it?

eriknordmark

Re-run

rucoder requested review from deitch, milan-zededa and eriknordmark as code owners October 31, 2024 14:58

github-actions bot requested review from jsfakian and shjala October 31, 2024 14:59

milan-zededa reviewed Oct 31, 2024

View reviewed changes

pkg/pillar/cmd/nim/nim.go Outdated Show resolved Hide resolved

milan-zededa reviewed Oct 31, 2024

View reviewed changes

OhmSpectator reviewed Oct 31, 2024

View reviewed changes

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

rucoder force-pushed the rucoder/monitor-agent branch from 4734622 to 0aa91aa Compare October 31, 2024 16:09

github-actions bot requested a review from milan-zededa October 31, 2024 16:09

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

eriknordmark reviewed Oct 31, 2024

View reviewed changes

rucoder force-pushed the rucoder/monitor-agent branch from 0aa91aa to 8fb1a58 Compare October 31, 2024 16:35

github-actions bot requested a review from eriknordmark October 31, 2024 16:36

christoph-zededa reviewed Oct 31, 2024

View reviewed changes

rucoder force-pushed the rucoder/monitor-agent branch from 8fb1a58 to d6c813e Compare October 31, 2024 17:19

rucoder force-pushed the rucoder/monitor-agent branch from e4ec643 to 95a773c Compare November 21, 2024 15:52

rucoder added 3 commits November 21, 2024 17:35

Add mismatching PCR indexes to VaultStatus

25543dc

Before this commit PCR indexes were present only in error text. Add them to VaultStatus to simplify further analysis Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Vendor required modules for monitor agent

5cb3ec9

- the monitor agent depends on a module to parse binary stream from Unix socket in predefined format Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

rucoder force-pushed the rucoder/monitor-agent branch from 95a773c to f3e3f82 Compare November 25, 2024 13:26

rucoder added 2 commits November 25, 2024 14:32

rucoder force-pushed the rucoder/monitor-agent branch from f3e3f82 to 67f8925 Compare November 25, 2024 13:32

rucoder requested review from christoph-zededa, rene and OhmSpectator November 25, 2024 13:38

christoph-zededa reviewed Nov 25, 2024

View reviewed changes

eriknordmark reviewed Nov 26, 2024

View reviewed changes

rucoder added 6 commits November 26, 2024 14:19

Add run-live-gui target to run monitor container

2ffa2e9

- monitor app is run only on physical monitor so we need to run QEMU with -vga or similar to see it Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Handle SetServer request

a4117a4

- Setting server URL in both /config/server and real config partition Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Add some comments to PubSub

ba58003

- Add comments for SubscriptionOptions.{WarningTime, ErrorTime} fields Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Add documentation for monitor TUI application

e6be920

- add documentation for pkg/monitor container - update NIM documentation - add documentation for pkg/pillar/cmd/monitor service Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

Update eve-monitor-rs tag

9d800b9

- Update tag to v0.1.1 which fixes is_onboarded() logic Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>

rucoder force-pushed the rucoder/monitor-agent branch from 67f8925 to 9d800b9 Compare November 26, 2024 13:25

github-actions bot requested a review from eriknordmark November 26, 2024 13:26

rucoder requested a review from christoph-zededa November 26, 2024 13:26

eriknordmark reviewed Nov 26, 2024

View reviewed changes

pkg/pillar/cmd/nim/nim.go Show resolved Hide resolved

milan-zededa reviewed Nov 26, 2024

View reviewed changes

eriknordmark approved these changes Nov 27, 2024

View reviewed changes

christoph-zededa reviewed Nov 27, 2024

View reviewed changes

eriknordmark approved these changes Nov 27, 2024

View reviewed changes

eriknordmark merged commit 57d6bc0 into lf-edge:master Nov 28, 2024
74 of 87 checks passed

		lastResort *types.DevicePortConfig
		manualDPC *types.DevicePortConfig

		RUN cp /app/target/$CARGO_BUILD_TARGET/release/monitor /app/target/


		FROM lfedge/eve-alpine:1f7685f95a475c6bbe682f0b976f12180b6c8726 AS runtime

	return fmt.Errorf("failed to find CONFIG partition: %v", err)
	return fmt.Errorf("failed to find CONFIG partition: %v -- output was: %s", err, string(deviceBytes))


		These limitations can be relaxed by using a custom font with 256 glyphs comparing to the standard one that uses 512 glyphs. In this case an extra bit can be used to render 16 colors. Besides extra pseudo-graphics glyphs can be added instead of unused characters to display e.g. rounded boxes.

		As of now a standard font is used so the look of the application on the host and on EVE is deferent

Add monitor application to EVE #4410

Add monitor application to EVE #4410

Conversation

rucoder commented Oct 31, 2024 • edited Loading

codecov bot commented Oct 31, 2024

Codecov Report

milan-zededa Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milan-zededa Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

milan-zededa Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eriknordmark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eriknordmark Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rucoder Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

eriknordmark left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eriknordmark left a comment

Choose a reason for hiding this comment

rucoder commented Oct 31, 2024 •

edited

Loading

milan-zededa Oct 31, 2024 •

edited

Loading

milan-zededa Oct 31, 2024 •

edited

Loading

milan-zededa Oct 31, 2024 •

edited

Loading

eriknordmark Nov 26, 2024 •

edited

Loading

rucoder Nov 26, 2024 •

edited

Loading