Disable iptables for L2-only traffic when everything is allowed by ACLs #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to ignore yetus suggestions, |
| allowRule := true | ||
| for _, action := range ace.Actions { | ||
| if action.Drop { | ||
| hasDropRule = true |
There was a problem hiding this comment.
Isn't it enough to mark that iptables are necessary in this case? I'm still trying to figure out why we should continue with the other checks after that.
There was a problem hiding this comment.
I have rewrote and split the function to avoid unnecessary checks.
OhmSpectator
approved these changes
Nov 15, 2024
Avoid using iptables for L2-forwaded traffic if ACLs allow everything (without rate limiting) and flow logging is disabled. Otherwise, unnecessary packet processing steps are added which reduce network performance significantly. In NFV use cases, filtering and flow logging are typically handled by applications (VNFs), so EVE should only focus on providing efficient virtual wiring. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
iptables-bypass
branch
from
5b4730f to
898472b
Compare
OhmSpectator
approved these changes
Nov 18, 2024
|
As I remember seeing all the Eden tests green, I consider the PR ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using iptables for L2-forwaded (application) traffic if ACLs allow everything (without rate limiting) and flow logging is disabled. Otherwise, unnecessary packet processing steps are added which reduce network performance significantly.
In NFV use cases, filtering and flow logging/monitoring are typically handled by applications (VNFs), so EVE should only focus on providing efficient virtual wiring.
This PR is part of a series of network performance optimizations coming into EVE, see documentation (will be submitted in a separate PR)