Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsock: set read/write timeout on the accepted connection #4450

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

shjala
Copy link
Member

@shjala shjala commented Nov 27, 2024

Set the read/write timeout on the accepted connection instead of the listener, otherwise accept will compain with EAGAIN every TIMEOUT seconds.

@shjala shjala requested a review from eriknordmark as a code owner November 27, 2024 21:03
Set the read/write timeout on the accepted connection instead of the
listner, otherwise accept will compain with EAGAIN every TIMEOUT seconds.

Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, how did we miss it during the previous review?

@shjala
Copy link
Member Author

shjala commented Nov 29, 2024

Oops, how did we miss it during the previous review?

yup, but it not that harmful.

@OhmSpectator OhmSpectator merged commit 6d42661 into lf-edge:master Nov 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants