Rust benchmarks that depend on childport references #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why it's broken is explained here: lf-lang/lingua-franca#1228 (comment)
jhaye
force-pushed
the
rust-childref-benches
branch
from
b9c9605 to
9f20d22
Compare
|
I think this is superseeded by #50. Please reopen if this not the case. |
|
This PR's changes are not contained within #50. It should be worked over and then merged. |
|
Oh, right. It actually added a benchmark. Sorry! |
|
@oowekyala do you want to take care of this? |
|
I've added a small checklist of remaining tasks for this PR. |
|
I'll take care of updating this |
There is a bug :( The start reaction is triggered by a port but the port has a missing value... Something probably went wrong during initialization but debugging this is hard.
cmnrd
force-pushed
the
rust-childref-benches
branch
from
9875a03 to
e98a385
Compare
|
APSP is now contained in #53 to be implemented later. This should be mergeable along with lf-lang/lingua-franca#1228, |
|
@oowekyala it looks like there is still a problem in the Matrix multiplication benchmark |
|
Looks like it's fixed now @cmnrd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the benchmarks that rely on referencing multiports as children in reactions. Things like:
This depends on lf-lang/lingua-franca#1228, which itself isn't finished yet.Remaining tasks