Fixed trimming of the recorded test output #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in our test framework. It seems like `Runtime.getRuntime().freeMemory()` does not indicate the total memory that can still be allocated, but only the free memory that is already allocated by the runtime. Therefore, the recorded output was often cut prematurely. This fix only considers the size of the recorded string buffer. It also makes sure, that the buffer is trimmed after deleting elements.
|
Thanks alot, Christian. The PR looks good, I am testing this fix on my feature-branch. And will report back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in our test framework. It seems like
Runtime.getRuntime().freeMemory()does not indicate the total memory that can still be allocated, but only the free memory that is already allocated by the runtime. Therefore, the recorded output was often cut prematurely. This fix only considers the size of the recorded string buffer. It also makes sure, that the buffer is trimmed after deleting elements.