-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lfc.ps1 to work in both dev and release setups #643
Conversation
@@ -18,5 +18,5 @@ fi | |||
# Make sure the correct JRE is available. | |||
check_jre_version | |||
|
|||
# Lunch the compiler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I have no way to testing it, however. In addition to these fixes, I think we need to add a check similar to the one performed in the Bash script for ensuring that a JRE >= 11 is installed.
Thanks for providing these fixes so expeditiously! We'll have this merged before the nightly build gets triggered. |
The Java version is checked on lines 43-47. I tested it on my machine for all possible cases (dev setup with JAR available/unavailable, release setup with JAR available/unavailable). |
Oh, sorry, I missed that. GitHub collapsed the view because those checks weren't part of the diff. |
Very cool. Thanks! |
This allows
lfc
to work in Windows in a way that is consistent with recent changes to the nightly build workflow and the corresponding Bash scripts. Related to #530.