Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lfc.ps1 to work in both dev and release setups #643

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

petervdonovan
Copy link
Collaborator

This allows lfc to work in Windows in a way that is consistent with recent changes to the nightly build workflow and the corresponding Bash scripts. Related to #530.

@petervdonovan petervdonovan marked this pull request as ready for review October 20, 2021 03:51
@petervdonovan petervdonovan requested a review from lhstrh October 20, 2021 03:51
@@ -18,5 +18,5 @@ fi
# Make sure the correct JRE is available.
check_jre_version

# Lunch the compiler.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I have no way to testing it, however. In addition to these fixes, I think we need to add a check similar to the one performed in the Bash script for ensuring that a JRE >= 11 is installed.

@lhstrh
Copy link
Member

lhstrh commented Oct 20, 2021

Thanks for providing these fixes so expeditiously! We'll have this merged before the nightly build gets triggered.

@petervdonovan
Copy link
Collaborator Author

In addition to these fixes, I think we need to add a check similar to the one performed in the Bash script for ensuring that a JRE >= 11 is installed.

The Java version is checked on lines 43-47.

I tested it on my machine for all possible cases (dev setup with JAR available/unavailable, release setup with JAR available/unavailable).

@petervdonovan petervdonovan merged commit a71eeaf into master Oct 20, 2021
@lhstrh
Copy link
Member

lhstrh commented Oct 20, 2021

In addition to these fixes, I think we need to add a check similar to the one performed in the Bash script for ensuring that a JRE >= 11 is installed.

The Java version is checked on lines 43-47.

I tested it on my machine for all possible cases (dev setup with JAR available/unavailable, release setup with JAR available/unavailable).

Oh, sorry, I missed that. GitHub collapsed the view because those checks weren't part of the diff.

@petervdonovan petervdonovan deleted the windows-lfc branch October 20, 2021 05:20
@cmnrd
Copy link
Collaborator

cmnrd commented Oct 20, 2021

Very cool. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants