Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds validation for protected main reactor parameters #804

Closed
wants to merge 2 commits into from
Closed

Adds validation for protected main reactor parameters #804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9435fe
Adds validation forprotected main reactor parameters
Rodario Dec 15, 2021
b21bc44
Update org.lflang/src/org/lflang/validation/LFValidator.xtend
lhstrh Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions org.lflang/src/org/lflang/validation/LFValidator.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,19 @@ class LFValidator extends BaseLFValidator {
if (param.inferredType.isUndefined()) {
error("Type declaration missing.", Literals.PARAMETER__TYPE)
}
}
if(this.target == Target.CPP) {
val container = param.eContainer
val reactor = container as Reactor
if(reactor.isMain){
// we need to check for the cli parameters that are always taken
val myList = #['t', 'threads', 'o', 'timeout', 'k', 'keepalive',
'f', 'fast', 'help']
if(myList.contains(param.name)){
error("Parameter '" + param.name + "' is already in use as command line argument by Lingua Franca,",
Literals.PARAMETER__NAME)
}
}
}

if (isCBasedTarget &&
Expand All @@ -761,8 +774,7 @@ class LFValidator extends BaseLFValidator {

if(!param.braces.isNullOrEmpty && this.target != Target.CPP) {
error("Brace initializers are only supported for the C++ target", Literals.PARAMETER__BRACES)
}

}
}

@Check(FAST)
Expand Down