-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary multi-board support for Arduino #141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different Arduino boards have different infrastructures, which requires us to determine what board type we are flashing to (AVR, SAM, SAMD, megaAVR, or MBED). Currently, the only change we need to make on reactor-c is ensuring MBED boards have a different call for disabling and enabling interrupts.
@erlingrj It may be good to see if this way of using compile-time params in the board type is sufficient. In cases where we need the specific board rather than its family, we can simply pull those up via referencing its specific compile-time macro. |
lhstrh
approved these changes
Jan 21, 2023
lhstrh
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different Arduino boards have different infrastructures, which requires us to determine what board type we are flashing to (AVR, SAM, SAMD, megaAVR, or MBED). Currently, the only change we need to make on reactor-c is ensuring MBED boards have a different call for disabling and enabling interrupts. This pull request will allow us to re-enable physical actions on Arduino boards.