Platform support for Raspberry Pi Pico #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
reviewed
Jun 19, 2023
core/platform/lf_pico_support.c
Outdated
Comment on lines
50
to
52
| /** | ||
| * Initialize the LF clock. Must be called before using other clock-related APIs. | ||
| */ |
There was a problem hiding this comment.
I think these function comments should appear only in the .h file unless they are somehow different for this implementation.
core/platform/lf_pico_support.c
Outdated
| * | ||
| * Ideally, the underlying platform clock should be monotonic. However, the | ||
| * core lib tries to enforce monotonicity at higher level APIs (see tag.h). | ||
| * TODO: might want to use the RTC |
There was a problem hiding this comment.
Maybe this should be an ordinary comment in the function body? It refers to the implementation, not the interface.
core/platform/lf_pico_support.c
Outdated
| * Lock a mutex. | ||
| * | ||
| * @return 0 on success, platform-specific error number otherwise. | ||
| * TODO: should this block? |
There was a problem hiding this comment.
Acquiring a mutex always needs to block.
merge in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform support for raspberry pi pico
some notes