Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont apply/subtract clock sync offset from NEVER/FOREVER #427

Merged
merged 2 commits into from
May 15, 2024
Merged

Dont apply/subtract clock sync offset from NEVER/FOREVER #427

merged 2 commits into from
May 15, 2024

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented May 13, 2024 •
edited
Loading

This caused an error when a worker tried to sleep FOREVER and and applied a positive offset and the wakeup instant wrapped and got negative.

@edwardalee: Note that this is a PR into your existing clock-sync PR. It might fix the CI issue

@erlingrj erlingrj requested a review from edwardalee May 13, 2024 17:29
@erlingrj erlingrj changed the base branch from main to clock-sync-initial May 13, 2024 17:31
@erlingrj erlingrj closed this May 13, 2024
@erlingrj erlingrj force-pushed the clock-sync-offset branch from 40bab7b to e5fef0c Compare May 13, 2024 17:33
@erlingrj erlingrj reopened this May 13, 2024
edwardalee
edwardalee approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The lf_tag_add function in tag.h/tag.c performs more complete checks of overflow and underflow. Maybe we should refactor this function into two, lf_time_add and lf_tag_add and then use lf_time_add for adding this offset.

@erlingrj erlingrj merged commit 5bdce8f into clock-sync-initial May 15, 2024
20 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardalee edwardalee edwardalee approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlingrj @edwardalee