-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Declarative Port Graph #46
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks interesting, but could you provide a high-level description of what this is meant to do? |
tanneberger
force-pushed
the
connection-optimization
branch
from
June 5, 2023 18:21
0716c15
to
93ff495
Compare
tanneberger
force-pushed
the
connection-optimization
branch
from
June 5, 2023 18:44
93ff495
to
00adab5
Compare
tanneberger
force-pushed
the
connection-optimization
branch
2 times, most recently
from
June 29, 2023 14:24
7e41093
to
5c6e72e
Compare
tanneberger
force-pushed
the
connection-optimization
branch
from
June 29, 2023 14:31
5c6e72e
to
4d1d18f
Compare
tanneberger
added a commit
that referenced
this pull request
Jul 25, 2023
Closing because #51 is the small tiny rewrite |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarative Port Graph
This pull request is a tremendous refactor of reactor-cpp instead of connecting ports in the assemble methods, this pull requests introduces a way to declarative define the port graph. On this more formal definition of a graph (
PropertyGraph
) I implemented a spanning tree style optimization that figures out all the connected downstream ports. Consequently, this spanning tree is then "flattened" into a tree of depth one in the process all the connections to every leaf of the tree is merged. This merging logic also takes Delayed, Enclaved and Physical connections into consideration.Important Changes for the Code Generator
Declaring the PortGraph
Start Up