Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding of NEVER and FOREVER in TimeValue class #120

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

byeonggiljun
Copy link
Collaborator

@byeonggiljun byeonggiljun commented Aug 24, 2022

Relevant issue: #118

Relevant LF PR: lf-lang/lingua-franca#1334
This should be merged before this PR is merged.

We need NEVER TimeValue to send RTI neighbor structure properly.

@byeonggiljun byeonggiljun requested review from hokeun and lhstrh August 24, 2022 06:47
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/core/time.ts Outdated Show resolved Hide resolved
@lhstrh lhstrh changed the title add NEVER and FOREVER TimeValue Encode NEVER and FOREVER in TimeValue class Aug 24, 2022
@lhstrh lhstrh changed the title Encode NEVER and FOREVER in TimeValue class Encoding of NEVER and FOREVER in TimeValue class Aug 24, 2022
@byeonggiljun byeonggiljun merged commit 554a861 into master Aug 24, 2022
@byeonggiljun byeonggiljun deleted the ts-never-timevalue branch August 25, 2022 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants