Normalisation improvement #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng as it was creating the training data from the already parsed units and not just from the plain tagged one - the slashes were gone for example #90
This was
linked to
issues
Jul 6, 2020
Closed
# Conflicts: # .travis.yml # build.gradle # resources/models/values/model.wapiti # src/main/java/org/grobid/core/data/normalization/QuantityNormaliser.java # src/main/java/org/grobid/core/engines/QuantitiesEngine.java # src/main/java/org/grobid/core/engines/QuantityParser.java # src/main/java/org/grobid/core/engines/UnitParser.java # src/main/java/org/grobid/core/features/FeaturesVectorQuantities.java # src/main/java/org/grobid/core/features/FeaturesVectorUnits.java # src/main/java/org/grobid/core/features/FeaturesVectorValues.java # src/main/java/org/grobid/core/utilities/MeasurementOperations.java # src/main/java/org/grobid/trainer/UnitTrainer.java # src/main/resources/lexicon/en/units.json # src/test/java/org/grobid/core/engines/UnitParserIntegrationTest.java # src/test/java/org/grobid/core/utilities/TextParserIntegrationTest.java
…normalisation-improvement # Conflicts: # build.gradle # gradle.properties # resources/models/values/model.wapiti # src/main/java/org/grobid/core/data/normalization/QuantityNormalizer.java # src/main/java/org/grobid/core/engines/QuantityParser.java # src/main/java/org/grobid/core/utilities/MeasurementOperations.java
# Conflicts: # .travis.yml # build.gradle # resources/models/values/model.wapiti # src/main/java/org/grobid/core/data/normalization/QuantityNormaliser.java # src/main/java/org/grobid/core/engines/QuantitiesEngine.java # src/main/java/org/grobid/core/engines/QuantityParser.java # src/main/java/org/grobid/core/engines/UnitParser.java # src/main/java/org/grobid/core/features/FeaturesVectorQuantities.java # src/main/java/org/grobid/core/features/FeaturesVectorUnits.java # src/main/java/org/grobid/core/features/FeaturesVectorValues.java # src/main/java/org/grobid/core/utilities/MeasurementOperations.java # src/main/java/org/grobid/trainer/UnitTrainer.java # src/main/resources/lexicon/en/units.json # src/test/java/org/grobid/core/engines/UnitParserIntegrationTest.java # src/test/java/org/grobid/core/utilities/TextParserIntegrationTest.java
…. imperial units) Adding notations from the UOM library which allow the disambiguation of overlapping units
|
I think, unless I forgot something, this PR is ready to be merged. |
|
Part of this PR was the update of the unit model. Before running the application, the user needs to run |
|
After updating is important to copy the models again. The Units and Values model has been updated in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I've improved the implementation for the normalisation:
58 ± 8 ml · kg −1 · min −1)I will merge it when the UOM library will be more stable and we will have more coverage.