Support width in percentage #30 #39
Conversation
t29mato
changed the title
t29mato
changed the title
lfoppiano
changed the title
| @@ -33,7 +33,7 @@ In the following table the list of parameters that can be provided to the `pdf_v | |||
| | name | description | | |||
| |-------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | input | The source of the PDF file. Accepts a file path, URL, or binary data. | | |||
| | width | Width of the PDF viewer in pixels. It defaults to 700 pixels. | | |||
| | width | The width of the PDF viewer defaults to 100% of the layout. Specify in pixels with a numeric value, or as a percentage for relative sizing. | | |||
| | height | Height of the PDF viewer in pixels. If not provided, the viewer shows the whole content. | | |||
There was a problem hiding this comment.
How about having height = 100% by default too?
There was a problem hiding this comment.
I've tried it and pushed it here 5443edb
But, it's outer height not inner height. The custom javascript returned 0 as value when I retrieve inner height because of iframe problem
ref: https://developer.mozilla.org/en-US/docs/Web/API/Window/outerHeight
There was a problem hiding this comment.
OK forget about it, we can address the height-related issue in #41
There was a problem hiding this comment.
So, do you think I should revert it? Because I've already pushed the code which supports outerHeight.
…er height which is supposed to be inner height
I've merged it. |
…ercentage # Conflicts: # streamlit_pdf_viewer/__init__.py
Support #30
Maybe this is solution for #35 and #37, too.