Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esbuild binary is installed in nested node_modules #3

Closed
lgarron opened this issue Jul 26, 2022 · 1 comment
Closed

esbuild binary is installed in nested node_modules #3

lgarron opened this issue Jul 26, 2022 · 1 comment

Comments

@lgarron
Copy link
Owner

lgarron commented Jul 26, 2022 •
edited
Loading

After running npm install in cubing.js, we end up with node_modules/barely-a-dev-server/node_modules/esbuild/bin/esbuild.

This:

  • might waste a bunch of disk space/bandwidth,
  • throw off some resolution algorithms, and
  • end up with different versions of esbuild used at the same time.

The situation seem similar to evanw/esbuild#1117 but I haven't been able to figure out what causes it. I'm going to try a few things.
lgarron added a commit that referenced this issue Jul 26, 2022
@lgarron
Change esbuild to a peer dependency. Hopefully mitigates #3.
8293c19
lgarron added a commit to cubing/cubing.js that referenced this issue Jul 26, 2022
@lgarron
[package.json] Update barely-a-dev-server to see if that fixes a bu…
efa966c 
…ndling issue.

See lgarron/barely-a-dev-server#3
@lgarron
Copy link
Owner Author

lgarron commented Jul 26, 2022 •
edited
Loading

With the peer dependency fix, seems resolved in cubing.js on my computer for now.

@lgarron lgarron closed this as completed Jul 26, 2022
lgarron added a commit to cubing/cubing.js that referenced this issue Jul 26, 2022
@lgarron
[package.json] Update barely-a-dev-server to see if that fixes a bu…
990b892 
…ndling issue.

See lgarron/barely-a-dev-server#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgarron