Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEGA65: VIC-IV alternate palettes on RRB #273

Closed
smnjameson opened this issue Jun 7, 2021 · 3 comments · Fixed by #274
Closed

MEGA65: VIC-IV alternate palettes on RRB #273

smnjameson opened this issue Jun 7, 2021 · 3 comments · Fixed by #274

Comments

@smnjameson
Copy link
Contributor

in NCM 16 color char mode alternate palettes can be selected by setting the BOLD + REVERSE attributes in the GOTOX marker. Note this relies on the extended attributes being disabled in bit5 of $d031 otherwise it will have no effect:

Expected:
image

Note how one of the moving balls is a different color

Xemu actual:
image

Test Files (Menu option B-D)
vic4tests.zip

@lgblgblgb lgblgblgb linked a pull request Jun 7, 2021 that will close this issue
lgblgblgb pushed a commit that referenced this issue Jun 7, 2021
* Added check for alternate palette in NCM RRB GOTOX

* Added check for alternate palette on GOTOX when using RRB in NCM mode

* removed my local build.sh script .. doh

Co-authored-by: smnjameson <smnjameson@googlemai.com>
@lgblgblgb
Copy link
Owner

So, it seems background also needs to use the "new" palette (the alternate palette) may be selected with GOTOXY. In fact as @smnjameson mentioned maybe everything from that point uses that palette (surely not sprites as those have separate palette optionally), not even restricted to NCM. Actually this is not too bad, I introduce the used_palette pointer which is initialized to the actual palette on each scanline start, but can be modified by the GOTOX token. Surely, renderers should use this used_palette then instead of the palette.

lgblgblgb added a commit that referenced this issue Jun 7, 2021
@lgblgblgb lgblgblgb changed the title MEGA65: VIC-IV NCM alternate palettes on RRB MEGA65: VIC-IV alternate palettes on RRB Jun 7, 2021
@lgblgblgb
Copy link
Owner

Edited issue name to better reflect it's not only for NCM

@lgblgblgb
Copy link
Owner

I consider this now as being done, since no more complains/bugs since them, I am aware of, at least.

lgblgblgb pushed a commit that referenced this issue Sep 22, 2021
* Added check for alternate palette in NCM RRB GOTOX

* Added check for alternate palette on GOTOX when using RRB in NCM mode

* removed my local build.sh script .. doh

Co-authored-by: smnjameson <smnjameson@googlemai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants