Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEGA65: Incorrect VIC-II bitmap fetch address #284

Closed
hernandp opened this issue Jul 21, 2021 · 4 comments · Fixed by #285
Closed

MEGA65: Incorrect VIC-II bitmap fetch address #284

hernandp opened this issue Jul 21, 2021 · 4 comments · Fixed by #285

Comments

@hernandp
Copy link
Contributor

hernandp commented Jul 21, 2021

Describe the bug
During character fetch, either in bitmap or text mode, the VICII bitmap address is set to CHARSET addr. This fails when e.g CHARSET is set to 14336 (with bits $D018 1-3 to 1110) since the only considered bit is 3 for bitmap.
So the effective VIC2 bitmap address should equal to MEGA65 24-bit Charset address with masked bits 0-12. This will keep bitmap (13) and DD00 bank (14-15) plus the upper MEGA65 additional bits.

The following program can be used for testing:

image

Correct output is (both in HW/xemu):
image

Incorrect output (fetch is displaced from 14336 instead of 8192):
image

Use BASICRAS.D81 provided for additional test.
BASICRAS.zip

@lgblgblgb
Copy link
Owner

Thanks! Merged to merger sounds funny ;) Btw I've edited your text above, since the hashmark number syntax creates references to other issues ... Unfortunately even after edit now it seems references remains at the target issues. Anyway, it won't kill me, just odd, that once it's done github does not provide any way to remove.

@hernandp
Copy link
Contributor Author

Thanks! Merged to merger sounds funny ;) Btw I've edited your text above, since the hashmark number syntax creates references to other issues ... Unfortunately even after edit now it seems references remains at the target issues. Anyway, it won't kill me, just odd, that once it's done github does not provide any way to remove.

You re welcome. Yeah that automatic referencing is useful but sometimes a bit odd ;)

@lgblgblgb
Copy link
Owner

Is there anything left here or can I close this issue?

@hernandp
Copy link
Contributor Author

@lgblgblgb It is done. Close this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants