Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt vrf related change for Buster #53

Merged
merged 1 commit into from
Mar 13, 2020
Merged

mgmt vrf related change for Buster #53

merged 1 commit into from
Mar 13, 2020

Conversation

bsun-sudo
Copy link

@bsun-sudo bsun-sudo commented Mar 13, 2020

- What I did
Partial code change for mgmt vrf related buster change.
This pull request removes cgcreate, cgset, cgdelete for l3mdev:mgmt in interfaces.j2, which are not applicable for linux 4.19.

- How I did it
In interfaces.j2, remove cgcreate, cgset, cgdelete for l3mdev:mgmt

- How to verify it
Test from click

  • config vrf add mgmt
    check ip vrf show from kernel
    ping remote ip, traceroute, scp with "ip vrf exec mgmt"
  • config vrf del mgmt
    check ip vrf show from kernel
    ping remote ip, traceroute, scp

for mgmt vrf add
//////////////////////
root@sonic:~# ip vrf show
Name Table

No VRF has been configured
root@sonic:#
root@sonic:
#
root@sonic:#
root@sonic:
# config vrf add mgmt

root@sonic:#
root@sonic:
#
root@sonic:~# ip vrf show
Name Table

mgmt 5000
root@sonic:#
root@sonic:
#
root@sonic:# ip vrf exec mgmt ping 10.14.8.140
PING 10.14.8.140 (10.14.8.140) 56(84) bytes of data.
64 bytes from 10.14.8.140: icmp_seq=1 ttl=61 time=2.07 ms
64 bytes from 10.14.8.140: icmp_seq=2 ttl=61 time=1.69 ms
^C
--- 10.14.8.140 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 2ms
rtt min/avg/max/mdev = 1.685/1.875/2.065/0.190 ms
root@sonic:
#

for mgmt vrf delete
//////////////////////

root@sonic:~# ip vrf show
Name Table

mgmt 5000
root@sonic:#
root@sonic:
#
root@sonic:#
root@sonic:
# config vrf del mgmt
root@sonic:#
root@sonic:
#
root@sonic:#
root@sonic:
# ip vrf show
Name Table

No VRF has been configured
root@sonic:#
root@sonic:
#
root@sonic:#
root@sonic:
# ping 10.14.8.140
PING 10.14.8.140 (10.14.8.140) 56(84) bytes of data.
64 bytes from 10.14.8.140: icmp_seq=1 ttl=61 time=1.95 ms
64 bytes from 10.14.8.140: icmp_seq=2 ttl=61 time=1.66 ms
64 bytes from 10.14.8.140: icmp_seq=3 ttl=61 time=1.66 ms
64 bytes from 10.14.8.140: icmp_seq=4 ttl=61 time=1.69 ms
^C
--- 10.14.8.140 ping statistics ---
4 packets transmitted, 4 received, 0% packet loss, time 7ms
rtt min/avg/max/mdev = 1.661/1.742/1.954/0.122 ms
root@sonic:~#

- Description for the changelog

modify interfaces.j2 for mgmt vrf handling in Buster

@lguohan lguohan merged commit b0b57bc into lguohan:master Mar 13, 2020
lguohan pushed a commit that referenced this pull request Mar 28, 2020
Co-authored-by: Bing Sun <Bing_Sun@dell.com>
lguohan pushed a commit that referenced this pull request Mar 29, 2020
Co-authored-by: Bing Sun <Bing_Sun@dell.com>
lguohan pushed a commit that referenced this pull request Apr 17, 2020
Co-authored-by: Bing Sun <Bing_Sun@dell.com>
lguohan pushed a commit that referenced this pull request Sep 19, 2020
- sonic-net/sonic-platform-daemons@1893c40
  - Fix the xcvrd theowing error on sfprecover function on getKeys() not valid.
- sonic-net/sonic-platform-daemons@65fa443
  - Merge pull request sonic-net#90 from abdosi/multiasic-fix
- sonic-net/sonic-platform-daemons@7f812c9
  - [xcvrd] Don't log unnecessary messages upon empty transceiver change event (#53)
- sonic-net/sonic-platform-daemons@0969202
  - Fix pcied daemon failure (sonic-net#91)

Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
lguohan pushed a commit that referenced this pull request Jan 20, 2021
[xcvrd] Don't log unnecessary messages upon empty transceiver change
event (#53)
    [thermalctld] Optimize the thermal policy loop to make it execute
    every 60 seconds (sonic-net#77)
     [thermalctld] Fix issue: fan status should not be True when fan is
     absent (sonic-net#92)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants