Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBSAN failures #443

Closed
armintoepfer opened this issue Jul 5, 2019 · 3 comments
Closed

UBSAN failures #443

armintoepfer opened this issue Jul 5, 2019 · 3 comments

Comments

@armintoepfer
Copy link
Contributor

armintoepfer commented Jul 5, 2019

Next round of sanitizer failures that I'd appreciate getting fixed so we can finally have a UBSAN passing CI run of pbmm2 ;)

minimap2/chain.c:158:2: runtime error: null pointer passed as argument 2, which is declared to never be null
minimap2/chain.c:159:2: runtime error: null pointer passed as argument 1, which is declared to never be null

I'm using tag v2.17.

@lh3 lh3 added bug enhancement and removed bug labels Jul 8, 2019
@lh3
Copy link
Owner

lh3 commented Jul 8, 2019

This is probably because minimap2 is memcpy-ing zero-length memory blocks. It should harmless and can probably by fixed by a check on the block length. I will come back to this later.

@lh3
Copy link
Owner

lh3 commented Jul 18, 2019

Could you check if d90583b fixes the issue? Thanks!

@armintoepfer
Copy link
Contributor Author

Works! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants